From 0058ba219e60a3e26fea07f7be7a2e625d5970c7 Mon Sep 17 00:00:00 2001
From: abhayjoshi201 <abhayjoshi201@gmail.com>
Date: Sat, 19 Oct 2024 14:28:58 +0530
Subject: [PATCH] Optimize Docker build script

---
 Docker/dev/build_images.sh | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/Docker/dev/build_images.sh b/Docker/dev/build_images.sh
index 2de827dfe..1f9e86ba3 100755
--- a/Docker/dev/build_images.sh
+++ b/Docker/dev/build_images.sh
@@ -1,24 +1,25 @@
-
 #!/bin/bash
 
 # Change directory to root Server directory for correct Docker Context
 cd ../..
 
-#Client
-client="./Docker/dev/client.Dockerfile"
+# Define an array of services and their Dockerfiles
+declare -A services=(
+  ["uptime_client"]="./Docker/dev/client.Dockerfile"
+  ["uptime_database_mongo"]="./Docker/dev/mongoDB.Dockerfile"
+  ["uptime_redis"]="./Docker/dev/redis.Dockerfile"
+  ["uptime_server"]="./Docker/dev/server.Dockerfile"
+)
 
-# MongoDB
-mongoDB="./Docker/dev/mongoDB.Dockerfile"
+# Loop through each service and build the corresponding image
+for service in "${!services[@]}"; do
+  docker build -f "${services[$service]}" -t "$service" .
+  
+  # Check if the build succeeded
+  if [ $? -ne 0 ]; then
+    echo "Error building $service image. Exiting..."
+    exit 1
+  fi
+done
 
-# Redis
-redis="./Docker/dev/redis.Dockerfile"
-
-# Server
-server="./Docker/dev/server.Dockerfile"
-
-docker build -f $client -t uptime_client .
-docker build -f $mongoDB -t uptime_database_mongo .
-docker build -f $redis -t uptime_redis .
-docker build -f $server -t uptime_server .
-
-echo "All images built"
\ No newline at end of file
+echo "All images built successfully"