From 0a11de47d77cb442885294b140feb68ccb0206fa Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Fri, 30 Aug 2024 10:09:38 -0700
Subject: [PATCH] Add admin guard to settings route, conditionally render
 config option

---
 Client/src/App.jsx                  |  3 +-
 Client/src/Pages/Settings/index.jsx | 66 ++++++++++++++++-------------
 2 files changed, 38 insertions(+), 31 deletions(-)

diff --git a/Client/src/App.jsx b/Client/src/App.jsx
index 88e1e7019..783f28330 100644
--- a/Client/src/App.jsx
+++ b/Client/src/App.jsx
@@ -39,6 +39,7 @@ function App() {
   const DetailsWithAdminProp = withAdminProp(Details);
   const PageSpeedWithAdminProp = withAdminProp(PageSpeed);
   const MaintenanceWithAdminProp = withAdminProp(Maintenance);
+  const SettingsWithAdminProp = withAdminProp(Settings);
 
   const mode = useSelector((state) => state.ui.mode);
 
@@ -90,7 +91,7 @@ function App() {
           />
           <Route
             path="settings"
-            element={<ProtectedRoute Component={Settings} />}
+            element={<ProtectedRoute Component={SettingsWithAdminProp} />}
           />
           <Route
             path="account/profile"
diff --git a/Client/src/Pages/Settings/index.jsx b/Client/src/Pages/Settings/index.jsx
index 06bc00e1e..c0295b572 100644
--- a/Client/src/Pages/Settings/index.jsx
+++ b/Client/src/Pages/Settings/index.jsx
@@ -10,7 +10,8 @@ import "./index.css";
 import { useDispatch, useSelector } from "react-redux";
 import { createToast } from "../../Utils/toastUtils";
 import { deleteMonitorChecksByTeamId } from "../../Features/UptimeMonitors/uptimeMonitorsSlice";
-const Settings = () => {
+import PropTypes from "prop-types";
+const Settings = ({ isAdmin }) => {
   const theme = useTheme();
   const { user, authToken } = useSelector((state) => state.auth);
   const { isLoading } = useSelector((state) => state.uptimeMonitors);
@@ -102,37 +103,39 @@ const Settings = () => {
             />
           </Stack>
         </ConfigBox>
-        <ConfigBox>
-          <Box>
-            <Typography component="h1">History and monitoring</Typography>
-            <Typography sx={{ mt: theme.spacing(2) }}>
-              Define here for how long you want to keep the data. You can also
-              remove all past data.
-            </Typography>
-          </Box>
-          <Stack gap={theme.spacing(20)}>
-            <Field
-              type="text"
-              id="history-monitoring"
-              label="The days you want to keep monitoring history."
-              isOptional={true}
-              optionalLabel="0 for infinite"
-              placeholder="90"
-              value=""
-              onChange={() => logger.warn("Disabled")}
-            />
+        {isAdmin && (
+          <ConfigBox>
             <Box>
-              <Typography>Clear all stats. This is irreversible.</Typography>
-              <ButtonSpinner
-                isLoading={isLoading}
-                level="error"
-                label="Clear all stats"
-                onClick={handleClearStats}
-                sx={{ mt: theme.spacing(4) }}
-              />
+              <Typography component="h1">History and monitoring</Typography>
+              <Typography sx={{ mt: theme.spacing(2) }}>
+                Define here for how long you want to keep the data. You can also
+                remove all past data.
+              </Typography>
             </Box>
-          </Stack>
-        </ConfigBox>
+            <Stack gap={theme.spacing(20)}>
+              <Field
+                type="text"
+                id="history-monitoring"
+                label="The days you want to keep monitoring history."
+                isOptional={true}
+                optionalLabel="0 for infinite"
+                placeholder="90"
+                value=""
+                onChange={() => logger.warn("Disabled")}
+              />
+              <Box>
+                <Typography>Clear all stats. This is irreversible.</Typography>
+                <ButtonSpinner
+                  isLoading={isLoading}
+                  level="error"
+                  label="Clear all stats"
+                  onClick={handleClearStats}
+                  sx={{ mt: theme.spacing(4) }}
+                />
+              </Box>
+            </Stack>
+          </ConfigBox>
+        )}
         <ConfigBox>
           <Box>
             <Typography component="h1">About</Typography>
@@ -163,4 +166,7 @@ const Settings = () => {
   );
 };
 
+Settings.propTypes = {
+  isAdmin: PropTypes.bool,
+};
 export default Settings;