refactor(client): drop rationale comments, name the icon control width
Review feedback from @malenacaroline on #3915: the theme pass carried too many comments, and they explain decisions rather than code. Remove 64 lines of rationale prose across 12 files. Everything taken out described *why* a value was chosen - which palette entry MUI derives what from, why a weight stays put, why a gradient lifts off `main`. That belongs in the PR description and commit history, not in an `sx` block where it goes stale the moment the palette moves. Two comments deliberately stay: - `StatusBox`: alpha() *replaces* the alpha channel rather than multiplying, so the faint grid depends on `divider` being an opaque hex. That is a live trap, not a design note. - `Table`: the `isRowSelected` JSDoc documents a real limitation of the prop (desktop table only), which a caller needs to know. Section labels (// Blues, // Hooks) are untouched. Also name the last bare number beside CONTROL_HEIGHT: the header icon links were `width: 36` next to `height: CONTROL_HEIGHT`. Now ICON_CONTROL_WIDTH. The other two `width: 36` sites are a switch track and a logo tile - same number, unrelated concepts, left alone. Gates: tsc clean, build ✓, format-check clean, lint unchanged from develop (12 errors, all pre-existing in untouched files).
This commit is contained in:
1 parent
de8eb53dd4
commit
17822b7cf6
13 files changed
+9
-66
No files matched your search
@@ -34,10 +34,6 @@ export const ToggleButtonInput = ({ sx, ...props }: ToggleButtonProps) => {
|
||||
},
|
||||
"&.Mui-selected": {
|
||||
backgroundColor: selectedBg,
|
||||
// Weight stays at 400 so the group sits level with Button,
|
||||
// which it is routinely placed beside. The fill and the
|
||||
// darker ink carry the selected state instead - a weight
|
||||
// change also reflows the label width as you switch.
|
||||
color: theme.palette.text.primary,
|
||||
"&:hover": {
|
||||
backgroundColor: selectedHoverBg,
|
||||
|
||||
Reference in new issue
Block a user