diff --git a/server/src/service/bufferService.ts b/server/src/service/bufferService.ts index 3b5619748..b5c20e49c 100755 --- a/server/src/service/bufferService.ts +++ b/server/src/service/bufferService.ts @@ -55,42 +55,15 @@ export class BufferService implements IBufferService { } addToBuffer(check: Check) { - try { - this.buffer.push(check); - } catch (error: unknown) { - this.logger.error({ - message: error instanceof Error ? error.message : "Unknown error", - service: this.SERVICE_NAME, - method: "addToBuffer", - stack: error instanceof Error ? error.stack : undefined, - }); - } + this.buffer.push(check); } addGeoCheckToBuffer(geoCheck: GeoCheck) { - try { - this.geoBuffer.push(geoCheck); - } catch (error: unknown) { - this.logger.error({ - message: error instanceof Error ? error.message : "Unknown error", - service: this.SERVICE_NAME, - method: "addGeoCheckToBuffer", - stack: error instanceof Error ? error.stack : undefined, - }); - } + this.geoBuffer.push(geoCheck); } addDockerLogToBuffer(dockerLog: DockerLog): void { - try { - this.dockerLogBuffer.push(dockerLog); - } catch (error: unknown) { - this.logger.error({ - message: error instanceof Error ? error.message : "Unknown error", - service: this.SERVICE_NAME, - method: "addDockerLogToBuffer", - stack: error instanceof Error ? error.stack : undefined, - }); - } + this.dockerLogBuffer.push(dockerLog); } scheduleNextFlush() { diff --git a/server/test/unit/services/bufferService.test.ts b/server/test/unit/services/bufferService.test.ts index bfcba9eaa..98ab4c47c 100644 --- a/server/test/unit/services/bufferService.test.ts +++ b/server/test/unit/services/bufferService.test.ts @@ -134,41 +134,6 @@ describe("BufferService", () => { expect(ingest).toHaveBeenCalledWith([check1, check2]); }); - - it("logs error if push throws", () => { - const { service, logger } = createService(); - // Force buffer.push to throw by making buffer non-extensible - Object.defineProperty(service, "buffer", { value: Object.freeze([]) }); - - service.addToBuffer(makeCheck()); - - expect(logger.error).toHaveBeenCalledWith( - expect.objectContaining({ - service: "BufferService", - method: "addToBuffer", - }) - ); - }); - - it("logs 'Unknown error' for non-Error thrown values", () => { - const { service, logger } = createService(); - Object.defineProperty(service, "buffer", { - value: { - push: () => { - throw "string error"; - }, - }, - }); - - service.addToBuffer(makeCheck()); - - expect(logger.error).toHaveBeenCalledWith( - expect.objectContaining({ - message: "Unknown error", - stack: undefined, - }) - ); - }); }); // ── addGeoCheckToBuffer ────────────────────────────────────────────── @@ -183,40 +148,6 @@ describe("BufferService", () => { expect(geoChecksService.createGeoChecks).toHaveBeenCalledWith([geoCheck]); }); - - it("logs error if push throws", () => { - const { service, logger } = createService(); - Object.defineProperty(service, "geoBuffer", { value: Object.freeze([]) }); - - service.addGeoCheckToBuffer(makeGeoCheck()); - - expect(logger.error).toHaveBeenCalledWith( - expect.objectContaining({ - service: "BufferService", - method: "addGeoCheckToBuffer", - }) - ); - }); - - it("logs 'Unknown error' for non-Error thrown values", () => { - const { service, logger } = createService(); - Object.defineProperty(service, "geoBuffer", { - value: { - push: () => { - throw 42; - }, - }, - }); - - service.addGeoCheckToBuffer(makeGeoCheck()); - - expect(logger.error).toHaveBeenCalledWith( - expect.objectContaining({ - message: "Unknown error", - stack: undefined, - }) - ); - }); }); describe("addDockerLogToBuffer", () => { @@ -229,15 +160,6 @@ describe("BufferService", () => { expect(dockerLogsService.createDockerLogs).toHaveBeenCalledWith([dockerLog]); }); - - it("logs an error if push throws", () => { - const { service, logger } = createService(); - Object.defineProperty(service, "dockerLogBuffer", { value: Object.freeze([]) }); - - service.addDockerLogToBuffer(makeDockerLog()); - - expect(logger.error).toHaveBeenCalledWith(expect.objectContaining({ method: "addDockerLogToBuffer" })); - }); }); // ── scheduleNextFlush ────────────────────────────────────────────────