From 25ff7abe7f1ad7542995a0ecefadb29efc518a93 Mon Sep 17 00:00:00 2001
From: Skorpios <cosmicray23@hotmail.com>
Date: Sat, 8 Mar 2025 16:44:52 -0800
Subject: [PATCH] refactored all the hardcoded absolute dimension values and
 made them into relative values that reference the theme.

---
 .../NotificationIntegrationModal.jsx          | 35 ++++++++++++++-----
 1 file changed, 26 insertions(+), 9 deletions(-)

diff --git a/src/Components/NotificationIntegrationModal/NotificationIntegrationModal.jsx b/src/Components/NotificationIntegrationModal/NotificationIntegrationModal.jsx
index d8955f18e..2522105a3 100644
--- a/src/Components/NotificationIntegrationModal/NotificationIntegrationModal.jsx
+++ b/src/Components/NotificationIntegrationModal/NotificationIntegrationModal.jsx
@@ -175,24 +175,30 @@ const NotificationIntegrationModal = ({
       maxWidth="md"
       sx={{
         '& .MuiDialog-paper': {
-          maxWidth: '775px'
+          width: `calc(90% - ${theme.spacing(40)})`, 
+          maxWidth: theme.breakpoints.values.md 
         }
       }}
     >
       <DialogContent>
-        <Box sx={{ display: 'flex', height: '300px' }}>
+        <Box sx={{ 
+          display: 'flex', 
+          height: `calc(26vh - ${theme.spacing(20)})` 
+        }}>
           {/* Left sidebar with tabs */}
           <Box sx={{ 
             borderRight: 1, 
-            borderColor: 'divider', 
-            minWidth: '200px',
+            borderColor: theme.palette.primary.lowContrast, 
+            width: '30%',
+            maxWidth: theme.spacing(120), 
             pr: theme.spacing(10)
           }}>
             <Typography variant="subtitle1" sx={{ 
               my: theme.spacing(1), 
               fontWeight: 'bold', 
-              fontSize: '0.9rem', 
-              color: theme.palette.primary.contrastTextSecondary 
+              fontSize: theme.typography.fontSize * 0.9, 
+              color: theme.palette.primary.contrastTextSecondary,
+              pl: theme.spacing(4)
             }}>
               Add or edit notifications
             </Typography>
@@ -205,13 +211,22 @@ const NotificationIntegrationModal = ({
               aria-label="Notification tabs"
             >
               {notificationTypes.map((type) => (
-                <Tab key={type.id} label={type.label} orientation="vertical" />
+                <Tab 
+                  key={type.id} 
+                  label={type.label} 
+                  orientation="vertical"
+                  disableRipple
+                />
               ))}
             </Tabs>
           </Box>
 
           {/* Right side content */}
-          <Box sx={{ flex: 1, pl: theme.spacing(7.5) }}>
+          <Box sx={{ 
+            flex: 1,
+            pl: theme.spacing(7.5),
+            overflowY: 'auto'
+          }}>
             {notificationTypes.map((type, index) => (
               <TabPanel key={type.id} value={tabValue} index={index}>
                 <TabComponent
@@ -238,7 +253,9 @@ const NotificationIntegrationModal = ({
           color="accent" 
           onClick={handleSave}
           sx={{ 
-            width: '120px'
+            width: 'auto', 
+            minWidth: theme.spacing(60), 
+            px: theme.spacing(8) 
           }}
         >
           Save