feat: reject custom CSS that references external resources
Reject status page custom CSS containing @import or a url() / image-set() / image() / cross-fade() whose target is http(s) or protocol-relative, while allowing data: and relative URLs. The check normalizes comments and CSS escapes first so obfuscated forms cannot slip past. Enforced in the create/update body validation.
This commit is contained in:
1 parent
6165ae60e6
commit
3685e0c476
4 files changed
+101
-1
No files matched your search
@@ -0,0 +1,23 @@
|
||||
// Normalize the CSS the way a browser does before matching, so obfuscated forms
|
||||
// (inline comments, CSS escapes like "\75 rl(") can't hide an external reference.
|
||||
const decodeForScan = (css: string): string =>
|
||||
css.replace(/\/\*[\s\S]*?\*\//g, "").replace(/\\([0-9a-fA-F]{1,6})\s?|\\([\s\S])/g, (_match, hex: string, char: string) => {
|
||||
if (!hex) {
|
||||
return char;
|
||||
}
|
||||
const codePoint = parseInt(hex, 16);
|
||||
return codePoint > 0 && codePoint <= 0x10ffff ? String.fromCodePoint(codePoint) : "�";
|
||||
});
|
||||
|
||||
// An external reference is @import, or a resource function (url, image-set,
|
||||
// image, cross-fade) whose target starts with an http(s) scheme or is
|
||||
// protocol-relative. Anchoring on the start of the target keeps data: and
|
||||
// relative URLs allowed, including data: SVG that embeds the SVG namespace URL.
|
||||
const EXTERNAL_REFERENCE = /(?:@import\b|(?:url|image-set|-webkit-image-set|image|cross-fade|-webkit-cross-fade)\s*\(\s*['"]?\s*(?:https?:|\/\/))/i;
|
||||
|
||||
export const cssReferencesExternalResource = (css?: string | null): boolean => {
|
||||
if (typeof css !== "string" || css === "") {
|
||||
return false;
|
||||
}
|
||||
return EXTERNAL_REFERENCE.test(decodeForScan(css));
|
||||
};
|
||||
Reference in new issue
Block a user