fix(client): correct StatBox hover and separate nested-control hover

Addresses review findings on the hover-states change.

StatBox's hover was a no-op. `GradientBox` always paints an opaque
`linear-gradient` via the `background` shorthand, which populates
background-image and covers any `backgroundColor` beneath it, so the new hover
was invisible — a regression from the `opacity: 0.95` it replaced. The overlay
now layers onto the same gradient, and moves into `GradientBox` where `bg` is
in scope, behind an `interactive` prop.

The mobile card branch gated its cursor and hover on `onRowClick` alone, so
expandable-row tables below the md breakpoint rendered cards that expand on
click but showed no pointer and no hover — the exact inconsistency this change
set out to fix, reintroduced on mobile. Both branches now share one
`isInteractive` flag.

The row action gear used the same overlay as the row beneath it. Alpha
overlays compose, so it was not invisible as reported, but the resulting delta
was 6 levels — too faint for a nested control. Adds `HOVER.CONTROL` (0.05) and
an `action.controlHover` token for controls nested inside a hoverable row: the
gear and the pagination arrows.

Claude-Session: https://claude.ai/code/session_01AbYLvwpEaZFXktHVcqrFRd
This commit is contained in:
gorkem-bwl committed 2026-08-28 19:53:39 -04:00
1 parent 9a6602b9e1
commit 3e56dc63a9
6 files changed
+24 -18

No files matched your search

@@ -79,6 +79,7 @@ export function DataTable<
};
const isSmall = useMediaQuery(theme.breakpoints.down("md"));
const isInteractive = Boolean(onRowClick) || expandableRows;
if (data.length === 0 || headers.length === 0) {
return (
@@ -107,8 +108,8 @@ export function DataTable<
borderColor: theme.palette.divider,
borderRadius: theme.shape.borderRadius,
padding: theme.spacing(LAYOUT.XS),
cursor: onRowClick ? "pointer" : "default",
...(onRowClick && {
cursor: isInteractive ? "pointer" : "default",
...(isInteractive && {
"&:hover": {
backgroundColor: theme.palette.action.rowHover,
},
@@ -240,9 +241,9 @@ export function DataTable<
return (
<Fragment key={key}>
<TableRow
className={onRowClick || expandableRows ? "is-clickable" : undefined}
className={isInteractive ? "is-clickable" : undefined}
sx={{
cursor: onRowClick || expandableRows ? "pointer" : "default",
cursor: isInteractive ? "pointer" : "default",
...(getRowSx?.(row) as object),
}}
onClick={() => {
@@ -328,7 +329,7 @@ function TablePaginationActions(props: TablePaginationActionsProps) {
flexShrink: 0,
ml: { xs: 0, md: 2.5 },
"& .MuiIconButton-root:not(.Mui-disabled):hover": {
backgroundColor: theme.palette.action.rowHover,
backgroundColor: theme.palette.action.controlHover,
},
}}
className="table-pagination-actions"
@@ -432,7 +433,7 @@ function HasMoreTablePaginationActions(props: HasMoreTablePaginationActionsProps
flexShrink: 0,
ml: { xs: 0, md: 2.5 },
"& .MuiIconButton-root:not(.Mui-disabled):hover": {
backgroundColor: theme.palette.action.rowHover,
backgroundColor: theme.palette.action.controlHover,
},
}}
className="table-pagination-actions"