purge unused groups route, update tests

This commit is contained in:
Alex Holliday committed 2026-07-20 10:21:43 -07:00
1 parent 5433a0cf5f
commit 4d9e5821a8
7 files changed
-43

No files matched your search

@@ -44,7 +44,6 @@ export interface IMonitorController {
getMonitorsWithChecksByTeamId: RequestHandler;
exportMonitorsToJSON: RequestHandler;
getAllGames: RequestHandler;
getGroupsByTeamId: RequestHandler;
updateNotifications: RequestHandler;
}
class MonitorController implements IMonitorController {
@@ -365,16 +364,6 @@ class MonitorController implements IMonitorController {
});
});
getGroupsByTeamId = catchAsync(async (req: Request, res: Response) => {
const teamId = requireTeamId(req.user?.teamId);
const groups = await this.monitorService.getGroupsByTeamId({ teamId });
return res.status(200).json({
msg: "Groups retrieved successfully",
data: groups,
});
});
updateNotifications = catchAsync(async (req: Request, res: Response) => {
updateNotificationsValidation.parse(req.body);
-1
View File
@@ -15,7 +15,6 @@ class MonitorRoutes {
// Team routes
this.router.get("/team", this.monitorController.getMonitorsByTeamId);
this.router.get("/team/with-checks", this.monitorController.getMonitorsWithChecksByTeamId);
this.router.get("/team/groups", this.monitorController.getGroupsByTeamId);
// Uptime routes
this.router.get("/uptime/details/:monitorId", this.monitorController.getUptimeDetailsById);
@@ -55,7 +55,6 @@ export interface IMonitorsRepository {
// other
findMonitorsSummaryByTeamId(teamId: string, config?: SummaryConfig): Promise<MonitorsSummary>;
findGroupsByTeamId(teamId: string): Promise<string[]>;
removeNotificationFromMonitors(notificationId: string): Promise<void>;
removeTagFromMonitors(tagId: string): Promise<void>;
updateNotifications(teamId: string, monitorIds: string[], notificationIds: string[], action: "add" | "remove" | "set"): Promise<number>;
@@ -382,14 +382,6 @@ class MongoMonitorsRepository implements IMonitorsRepository {
);
};
findGroupsByTeamId = async (teamId: string): Promise<string[]> => {
const groups = await MonitorModel.distinct("group", {
teamId: new mongoose.Types.ObjectId(teamId),
group: { $nin: [null, ""] },
});
return groups.sort();
};
removeNotificationFromMonitors = async (notificationId: string): Promise<void> => {
await MonitorModel.updateMany({ notifications: notificationId }, { $pull: { notifications: notificationId } });
};
@@ -72,7 +72,6 @@ export interface IMonitorService {
order?: "asc" | "desc";
}): Promise<MonitorsWithChecksByTeamIdResult>;
getAllGames(): GamesMap;
getGroupsByTeamId(args: { teamId: string }): Promise<string[]>;
// update
editMonitor(args: { teamId: string; monitorId: string; body: Partial<Monitor> }): Promise<Monitor>;
@@ -422,10 +421,6 @@ export class MonitorService implements IMonitorService {
return this.games;
};
getGroupsByTeamId = async ({ teamId }: { teamId: string }): Promise<string[]> => {
return await this.monitorsRepository.findGroupsByTeamId(teamId);
};
editMonitor = async ({ teamId, monitorId, body }: { teamId: string; monitorId: string; body: Partial<Monitor> }) => {
const editedMonitor = await this.monitorsRepository.updateById(monitorId, teamId, body);
await this.scheduler.updateJob(editedMonitor);