From 54c94879d7115001c902d34bf754c097cb5b8ad8 Mon Sep 17 00:00:00 2001 From: Alex Holliday Date: Wed, 22 May 2024 14:43:07 -0700 Subject: [PATCH] Changed delete status code to 200 to allow for consistent API response, Updated docs to reflect this --- README.md | 11 ++++++++++- Server/controllers/monitorController.js | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9d362d5c3..44a30ea94 100644 --- a/README.md +++ b/README.md @@ -454,7 +454,7 @@ curl --request POST \ > | ---- | ------------------- | > | None | No payload returned | -##### Sample CURL request +###### Sample CURL request ``` curl --request POST \ @@ -463,6 +463,15 @@ curl --request POST \ --header 'Content-Type: application/json' \ ``` +###### Sample Response + +```json +{ + "success": true, + "msg": "Monitor deleted" +} +``` + ## --- diff --git a/Server/controllers/monitorController.js b/Server/controllers/monitorController.js index cf245fba3..f004f98f3 100644 --- a/Server/controllers/monitorController.js +++ b/Server/controllers/monitorController.js @@ -135,7 +135,7 @@ const deleteMonitor = async (req, res) => { * when it is deleted so there is no orphaned data * We also need to make sure to stop all running services for this monitor */ - return res.status(204).json({ success: true, msg: "Monitor deleted" }); + return res.status(200).json({ success: true, msg: "Monitor deleted" }); } catch (error) { logger.error(error.message, { service: "monitor" }); return res.status(500).json({ success: false, msg: error.message });