refactor: extract isStatusUp utility to decouple from got's response.ok and modified utils test accordingly

This commit is contained in:
harsh-aghara committed 2026-06-04 22:43:43 +05:30
1 parent 372fc9869b
commit 5628c202f7
5 files changed
+50 -8

No files matched your search

@@ -254,14 +254,13 @@ describe("HttpProvider", () => {
expect(result.extracted).toBe("value");
});
it("sets status to false when response.ok is false even if matcher passes", async () => {
it("sets status to false when status code is non-2xx even if matcher passes", async () => {
mockGot.mockResolvedValue(makeGotResponse({ ok: false, statusCode: 301 }));
const matcher = createMockMatcher({ ok: true, message: "Success" });
const { provider } = createProvider(matcher);
const result = await provider.handle(makeMonitor());
// status = response.ok && matchResult.ok
expect(result.status).toBe(false);
});
});
@@ -1,5 +1,5 @@
import { describe, expect, it } from "@jest/globals";
import { timeRequest, NETWORK_ERROR, PING_ERROR } from "../../../../src/service/infrastructure/network/utils.ts";
import { timeRequest, NETWORK_ERROR, PING_ERROR, isStatusUp } from "../../../../src/service/infrastructure/network/utils.ts";
describe("network utils", () => {
describe("timeRequest", () => {
@@ -41,4 +41,40 @@ describe("network utils", () => {
expect(PING_ERROR).toBe(5001);
});
});
describe("isStatusUp", () => {
it("returns true for 2xx status codes", () => {
expect(isStatusUp(200)).toBe(true);
expect(isStatusUp(201)).toBe(true);
expect(isStatusUp(204)).toBe(true);
expect(isStatusUp(299)).toBe(true);
});
it("returns false for non-2xx status codes without customUpCodes", () => {
expect(isStatusUp(100)).toBe(false);
expect(isStatusUp(301)).toBe(false);
expect(isStatusUp(404)).toBe(false);
expect(isStatusUp(500)).toBe(false);
});
it("returns true when status code is in customUpCodes", () => {
expect(isStatusUp(301, [301])).toBe(true);
expect(isStatusUp(404, [200, 404])).toBe(true);
expect(isStatusUp(401, [401, 403])).toBe(true);
});
it("returns false when status code is not in customUpCodes", () => {
expect(isStatusUp(500, [401, 403])).toBe(false);
});
it("returns false when statusCode is undefined", () => {
expect(isStatusUp(undefined)).toBe(false);
expect(isStatusUp(undefined, [200])).toBe(false);
});
it("defaults customUpCodes to empty array", () => {
expect(isStatusUp(200)).toBe(true);
expect(isStatusUp(404)).toBe(false);
});
});
});