Refactored hardcoded error messages to util file. Added logging to job queue

This commit is contained in:
Alex Holliday committed 2024-06-14 13:45:45 -07:00
1 parent 1ad32ed84b
commit 5da22f4403
10 files changed
+138 -60

No files matched your search

+11 -9
View File
@@ -10,7 +10,7 @@ const {
editAlertBodyValidation,
deleteAlertParamValidation,
} = require("../validation/joi");
const { successMessages } = require("../utils/messages");
const SERVICE_NAME = "alerts";
/**
@@ -38,7 +38,7 @@ const createAlert = async (req, res, next) => {
const alert = await req.db.createAlert(alertData);
return res
.status(200)
.json({ success: true, msg: "Alert created", data: alert });
.json({ success: true, msg: successMessages.ALERT_CREATE, data: alert });
} catch (error) {
error.service = SERVICE_NAME;
next(error);
@@ -66,9 +66,11 @@ const getAlertsByUserId = async (req, res, next) => {
try {
const alerts = await req.db.getAlertsByUserId(req.params.userId);
return res
.status(200)
.json({ success: true, msg: "Got alerts", data: alerts });
return res.status(200).json({
success: true,
msg: successMessages.ALERT_GET_BY_USER,
data: alerts,
});
} catch (error) {
error.service = SERVICE_NAME;
next(error);
@@ -90,7 +92,7 @@ const getAlertsByMonitorId = async (req, res, next) => {
const alerts = await req.db.getAlertsByMonitorId(req.params.monitorId);
return res.status(200).json({
success: true,
msg: "Got alerts by Monitor",
msg: successMessages.ALERT_GET_BY_MONITOR,
data: alerts,
});
} catch (error) {
@@ -114,7 +116,7 @@ const getAlertById = async (req, res, next) => {
const alert = await req.db.getAlertById(req.params.alertId);
return res.status(200).json({
success: true,
msg: "Got Alert By alertID",
msg: successMessages.ALERT_GET_BY_ID,
data: alert,
});
} catch (error) {
@@ -141,7 +143,7 @@ const editAlert = async (req, res, next) => {
const alert = await req.db.editAlert(req.params.alertId, alertData);
return res.status(200).json({
success: true,
msg: "Edited alert",
msg: successMessages.ALERT_EDIT,
data: alert,
});
} catch (error) {
@@ -164,7 +166,7 @@ const deleteAlert = async (req, res, next) => {
const deleted = await req.db.deleteAlert(req.params.alertId);
return res.status(200).json({
success: true,
msg: "Deleted alert",
msg: successMessages.ALERT_DELETE,
data: deleted,
});
} catch (error) {