Merge pull request #244 from bluewave-labs/feat/picture-validation

Added validation to picture uploads, resolves #213
This commit is contained in:
Alexander Holliday authored and GitHub committed 2024-07-02 12:58:12 -07:00
commit 65d55c239f
6 files changed
+132 -29

No files matched your search

@@ -16,3 +16,16 @@
.progress-bar-container p.MuiTypography-root span { .progress-bar-container p.MuiTypography-root span {
padding-left: 2px; padding-left: 2px;
} }
.progress-bar-container:has(p.input-error){
border-color: var(--env-var-color-24);
padding: 8px var(--env-var-spacing-1-plus);
}
.progress-bar-container p.input-error{
color: var(--env-var-color-24);
opacity: 0.8;
}
.progress-bar-container:has(p.input-error)>.MuiStack-root>svg{
fill: var(--env-var-color-24);
width: 20px;
height: 20px;
}
+43 -12
View File
@@ -9,6 +9,7 @@ import {
Typography, Typography,
} from "@mui/material"; } from "@mui/material";
import CloseIcon from "@mui/icons-material/Close"; import CloseIcon from "@mui/icons-material/Close";
import ErrorOutlineOutlinedIcon from "@mui/icons-material/ErrorOutlineOutlined";
import "./index.css"; import "./index.css";
/** /**
@@ -18,10 +19,18 @@ import "./index.css";
* @param {string} props.size - The size information for the progress item. * @param {string} props.size - The size information for the progress item.
* @param {number} props.progress - The current progress value (0-100). * @param {number} props.progress - The current progress value (0-100).
* @param {function} props.onClick - The function to handle click events on the remove button. * @param {function} props.onClick - The function to handle click events on the remove button.
* @param {string} props.error - Error message to display if there's an error (optional).
* @returns {JSX.Element} The rendered component. * @returns {JSX.Element} The rendered component.
*/ */
const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => { const ProgressUpload = ({
icon,
label,
size,
progress = 0,
onClick,
error,
}) => {
const theme = useTheme(); const theme = useTheme();
return ( return (
<Box <Box
@@ -34,8 +43,15 @@ const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => {
border: `solid 1px ${theme.palette.otherColors.graishWhite}`, border: `solid 1px ${theme.palette.otherColors.graishWhite}`,
}} }}
> >
<Stack direction="row" mb="10px" gap="10px" alignItems="flex-end"> <Stack
{icon ? ( direction="row"
mb={error ? "0" : "10px"}
gap="10px"
alignItems={error ? "center" : "flex-end"}
>
{error ? (
<ErrorOutlineOutlinedIcon />
) : icon ? (
<IconButton <IconButton
sx={{ sx={{
backgroundColor: theme.palette.otherColors.white, backgroundColor: theme.palette.otherColors.white,
@@ -50,17 +66,23 @@ const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => {
) : ( ) : (
"" ""
)} )}
{error ? (
<Typography component="p" className="input-error">
{error}
</Typography>
) : (
<Box> <Box>
<Typography variant="h4" component="h2" mb="5px"> <Typography component="h2" mb="5px">
{label} {error ? error : label}
</Typography>
<Typography variant="h4" component="p">
{size}
</Typography> </Typography>
<Typography component="p">{!error && size}</Typography>
</Box> </Box>
)}
<IconButton <IconButton
onClick={onClick} onClick={onClick}
sx={{ sx={
!error
? {
alignSelf: "flex-start", alignSelf: "flex-start",
ml: "auto", ml: "auto",
mr: "-5px", mr: "-5px",
@@ -69,7 +91,11 @@ const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => {
"&:focus": { "&:focus": {
outline: "none", outline: "none",
}, },
}} }
: {
ml: "auto",
}
}
> >
<CloseIcon <CloseIcon
sx={{ sx={{
@@ -78,6 +104,7 @@ const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => {
/> />
</IconButton> </IconButton>
</Stack> </Stack>
{!error ? (
<Stack direction="row" alignItems="center"> <Stack direction="row" alignItems="center">
<Box sx={{ width: "100%", mr: "10px" }}> <Box sx={{ width: "100%", mr: "10px" }}>
<LinearProgress <LinearProgress
@@ -86,17 +113,20 @@ const ProgressUpload = ({ icon, label, size, progress = 0, onClick }) => {
sx={{ sx={{
width: "100%", width: "100%",
height: "10px", height: "10px",
borderRadius: theme.shape.borderRadius, borderRadius: `${theme.shape.borderRadius}px`,
maxWidth: "500px", maxWidth: "500px",
backgroundColor: theme.palette.otherColors.graishWhite, backgroundColor: theme.palette.otherColors.graishWhite,
}} }}
/> />
</Box> </Box>
<Typography variant="h4" component="p" sx={{ minWidth: "max-content" }}> <Typography component="p" sx={{ minWidth: "max-content" }}>
{progress} {progress}
<span>%</span> <span>%</span>
</Typography> </Typography>
</Stack> </Stack>
) : (
""
)}
</Box> </Box>
); );
}; };
@@ -107,6 +137,7 @@ ProgressUpload.propTypes = {
size: PropTypes.string.isRequired, // Size information for the progress item size: PropTypes.string.isRequired, // Size information for the progress item
progress: PropTypes.number.isRequired, // Current progress value (0-100) progress: PropTypes.number.isRequired, // Current progress value (0-100)
onClick: PropTypes.func.isRequired, // Function to handle click events on the remove button onClick: PropTypes.func.isRequired, // Function to handle click events on the remove button
error: PropTypes.string, // Error message to display if there's an error (optional)
}; };
export default ProgressUpload; export default ProgressUpload;
@@ -7,7 +7,10 @@ import Button from "../../Button";
import EmailTextField from "../../TextFields/Email/EmailTextField"; import EmailTextField from "../../TextFields/Email/EmailTextField";
import StringTextField from "../../TextFields/Text/TextField"; import StringTextField from "../../TextFields/Text/TextField";
import Avatar from "../../Avatar"; import Avatar from "../../Avatar";
import { editProfileValidation } from "../../../Validation/validation"; import {
editProfileValidation,
imageValidation,
} from "../../../Validation/validation";
import { useDispatch, useSelector } from "react-redux"; import { useDispatch, useSelector } from "react-redux";
import { update } from "../../../Features/Auth/authSlice"; import { update } from "../../../Features/Auth/authSlice";
import ImageField from "../../TextFields/Image"; import ImageField from "../../TextFields/Image";
@@ -76,12 +79,30 @@ const ProfilePanel = () => {
const [uploadProgress, setUploadProgress] = useState(0); const [uploadProgress, setUploadProgress] = useState(0);
const [isUploading, setIsUploading] = useState(false); const [isUploading, setIsUploading] = useState(false);
const handlePicture = (event) => { const handlePicture = (event) => {
clearError("picture");
const pic = event.target.files[0]; const pic = event.target.files[0];
console.log(pic); console.log(pic);
//TODO - add setPicture state to localData //TODO - add setPicture state to localData
setPicture({ name: pic.name, type: pic.type, size: formatBytes(pic.size) }); setPicture({ name: pic.name, type: pic.type, size: formatBytes(pic.size) });
setIsUploading(true); setIsUploading(true);
const { error } = imageValidation.validate(
{
type: pic.type,
size: pic.size,
},
{ abortEarly: false }
);
if (error) {
setErrors((prev) => {
const updatedErrors = { ...prev };
updatedErrors["picture"] = error.details[0].message;
return updatedErrors;
});
return;
}
setTimeout(() => { setTimeout(() => {
//TODO - add setPicture state to localData //TODO - add setPicture state to localData
setPicture((prev) => ({ ...prev, src: URL.createObjectURL(pic) })); setPicture((prev) => ({ ...prev, src: URL.createObjectURL(pic) }));
@@ -98,20 +119,28 @@ const ProfilePanel = () => {
}; };
const formatBytes = (bytes) => { const formatBytes = (bytes) => {
if (bytes === 0) return "0 Bytes"; if (bytes === 0) return "0 Bytes";
const k = 1024; const megabytes = bytes / (1024 * 1024);
const i = Math.floor(Math.log(bytes) / Math.log(k)); return megabytes.toFixed(2) + " MB";
return parseFloat((bytes / Math.pow(k, i)).toFixed(2)) + " MB"; };
const clearError = (err) => {
setErrors((prev) => {
const updatedErrors = { ...prev };
if (updatedErrors[err]) delete updatedErrors[err];
return updatedErrors;
});
}; };
const handleCancelUpload = () => { const handleCancelUpload = () => {
//TODO - add setPicture state to localData //TODO - add setPicture state to localData
setPicture(null); setPicture();
setUploadProgress(0); setUploadProgress(0);
setIsUploading(false); setIsUploading(false);
clearError("picture");
}; };
const handleClosePictureModal = () => { const handleClosePictureModal = () => {
setIsOpen(""); setIsOpen("");
setUploadProgress(0); setUploadProgress(0);
setIsUploading(false); setIsUploading(false);
clearError("picture");
}; };
//TODO - revisit once localData is set up properly //TODO - revisit once localData is set up properly
@@ -353,7 +382,6 @@ const ProfilePanel = () => {
aria-describedby="update-profile-picture" aria-describedby="update-profile-picture"
open={isModalOpen("picture")} open={isModalOpen("picture")}
onClose={handleClosePictureModal} onClose={handleClosePictureModal}
disablePortal
> >
<Stack <Stack
sx={{ sx={{
@@ -387,6 +415,7 @@ const ProfilePanel = () => {
size={picture?.size} size={picture?.size}
progress={uploadProgress} progress={uploadProgress}
onClick={handleCancelUpload} onClick={handleCancelUpload}
error={errors["picture"]}
/> />
) : ( ) : (
"" ""
@@ -1,13 +1,27 @@
.image-field-wrapper h2.MuiTypography-root, .image-field-wrapper h2.MuiTypography-root,
.image-field-wrapper p.MuiTypography-root { .image-field-wrapper p.MuiTypography-root,
.image-field-wrapper + p.MuiTypography-root,
.MuiStack-root:has(#modal-update-picture) h1.MuiTypography-root {
color: var(--env-var-color-2); color: var(--env-var-color-2);
}
.MuiStack-root:has(#modal-update-picture) h1.MuiTypography-root {
font-weight: 600;
}
.image-field-wrapper h2.MuiTypography-root,
.MuiStack-root:has(#modal-update-picture) button,
.MuiStack-root:has(#modal-update-picture) h1.MuiTypography-root {
font-size: var(--env-var-font-size-medium); font-size: var(--env-var-font-size-medium);
} }
.image-field-wrapper h2.MuiTypography-root { .image-field-wrapper h2.MuiTypography-root {
margin-top: 10px; margin-top: 10px;
} }
.image-field-wrapper + p.MuiTypography-root {
margin-top: 8px;
}
.image-field-wrapper + p.MuiTypography-root,
.image-field-wrapper p.MuiTypography-root { .image-field-wrapper p.MuiTypography-root {
opacity: 0.8; opacity: 0.6;
font-size: var(--env-var-font-size-small-plus);
} }
.image-field-wrapper h2.MuiTypography-root span { .image-field-wrapper h2.MuiTypography-root span {
color: var(--env-var-color-3); color: var(--env-var-color-3);
@@ -27,6 +27,7 @@ const ImageField = ({ id, picture, onChange }) => {
return ( return (
<> <>
{!picture ? ( {!picture ? (
<>
<Box <Box
className="image-field-wrapper" className="image-field-wrapper"
mt="20px" mt="20px"
@@ -59,7 +60,7 @@ const ImageField = ({ id, picture, onChange }) => {
opacity: 0, opacity: 0,
cursor: "pointer", cursor: "pointer",
maxWidth: "500px", maxWidth: "500px",
minHeight: "175px" minHeight: "175px",
}, },
"& fieldset": { "& fieldset": {
padding: 0, padding: 0,
@@ -70,7 +71,7 @@ const ImageField = ({ id, picture, onChange }) => {
<Stack <Stack
className="custom-file-text" className="custom-file-text"
alignItems="center" alignItems="center"
gap="10px" gap="4px"
sx={{ sx={{
position: "absolute", position: "absolute",
top: "50%", top: "50%",
@@ -90,14 +91,14 @@ const ImageField = ({ id, picture, onChange }) => {
> >
<CloudUploadIcon /> <CloudUploadIcon />
</IconButton> </IconButton>
<Typography variant="h4" component="h2"> <Typography component="h2">
<span>Click to upload</span> or drag and drop <span>Click to upload</span> or drag and drop
</Typography> </Typography>
<Typography variant="h4" component="p"> <Typography component="p">(maximum size: 3MB)</Typography>
(max. 800x400px)
</Typography>
</Stack> </Stack>
</Box> </Box>
<Typography component="p">Supported formats: JPG, PNG</Typography>
</>
) : ( ) : (
<Stack direction="row" justifyContent="center"> <Stack direction="row" justifyContent="center">
<Box <Box
@@ -107,10 +108,9 @@ const ImageField = ({ id, picture, onChange }) => {
borderRadius: "50%", borderRadius: "50%",
overflow: "hidden", overflow: "hidden",
backgroundImage: `url(${picture})`, backgroundImage: `url(${picture})`,
backgroundSize: "cover" backgroundSize: "cover",
}} }}
> ></Box>
</Box>
</Stack> </Stack>
)} )}
</> </>
+16
View File
@@ -150,7 +150,23 @@ const createMonitorValidation = joi.object({
}), }),
}); });
const imageValidation = joi.object({
type: joi.string().valid("image/jpeg", "image/png").messages({
"any.only": "Invalid file format.",
"string.empty": "File type required.",
}),
size: joi
.number()
.max(3 * 1024 * 1024)
.messages({
"number.base": "File size must be a number.",
"number.max": "File size must be less than 3 MB.",
"number.empty": "File size required.",
}),
});
export { export {
imageValidation,
createMonitorValidation, createMonitorValidation,
registerValidation, registerValidation,
loginValidation, loginValidation,