From 66bc2a823860f2b46acdc0cee982961e397fd644 Mon Sep 17 00:00:00 2001 From: Br0wnHammer Date: Tue, 18 Mar 2025 22:20:25 +0530 Subject: [PATCH] Feat: Migrate Hardcoded Strings --- .../Maintenance/MaintenanceTable/ActionsMenu/index.jsx | 6 +++--- src/Pages/PageSpeed/Configure/index.jsx | 2 +- src/locales/gb.json | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/Pages/Maintenance/MaintenanceTable/ActionsMenu/index.jsx b/src/Pages/Maintenance/MaintenanceTable/ActionsMenu/index.jsx index 9bddf1b92..aa1c48433 100644 --- a/src/Pages/Maintenance/MaintenanceTable/ActionsMenu/index.jsx +++ b/src/Pages/Maintenance/MaintenanceTable/ActionsMenu/index.jsx @@ -135,7 +135,7 @@ const ActionsMenu = ({ /* isAdmin, */ maintenanceWindow, updateCallback }) => { e.stopPropagation(); }} > - {`${maintenanceWindow.active === true ? "Pause" : "Resume"}`} + {`${maintenanceWindow.active === true ? t("pause") : t("resume")}`} { { e.stopPropagation(); setIsOpen(false); }} - confirmationButtonLabel={"Delete"} + confirmationButtonLabel={t("delete")} onConfirm={(e) => { e.stopPropagation(e); handleRemove(e); diff --git a/src/Pages/PageSpeed/Configure/index.jsx b/src/Pages/PageSpeed/Configure/index.jsx index 6f640ffb3..d9753ef2c 100644 --- a/src/Pages/PageSpeed/Configure/index.jsx +++ b/src/Pages/PageSpeed/Configure/index.jsx @@ -442,7 +442,7 @@ const PageSpeedConfigure = () => { title={t("deleteDialogTitle")} description={t("deleteDialogDescription")} onCancel={() => setIsOpen(false)} - confirmationButtonLabel={"Delete"} + confirmationButtonLabel={t("delete")} onConfirm={handleRemove} isLoading={buttonLoading} /> diff --git a/src/locales/gb.json b/src/locales/gb.json index 7c64a83e4..6f94d01ba 100644 --- a/src/locales/gb.json +++ b/src/locales/gb.json @@ -200,7 +200,7 @@ "notFoundButton": "Go to the main dashboard", "pageSpeedConfigureSettingsDescription": "Here you can select the URL of the host, together with the type of monitor.", "monitorDisplayName": "Monitor display name", - "whenNewIncident,": "When there is a new incident,", + "whenNewIncident": "When there is a new incident,", "notifySMS": "Notify via SMS (coming soon)", "notifyEmails": "Also notify via email to multiple addresses (coming soon)", "seperateEmails": "You can separate multiple emails with a comma", @@ -240,6 +240,7 @@ "uptimeCreate": "The expected value is used to match against response result, and the match determines the status.", "uptimeCreateJsonPath": "This expression will be evaluated against the reponse JSON data and the result will be used to match against the expected value. See", "uptimeCreateJsonPathQuery": "for query language documentation.", + "maintenanceTableActionMenuDialogTitle": "Do you really want to remove this maintenance window?", "notifications": { "enableNotifications": "Enable {{platform}} notifications", "testNotification": "Test notification",