extract password validation, add regression test

This commit is contained in:
Alex Holliday committed 2026-05-15 11:14:39 -07:00
1 parent f46c2edd1b
commit 704f25b987
3 files changed
+70 -25

No files matched your search

@@ -0,0 +1,46 @@
import { describe, expect, it } from "@jest/globals";
import { editUserBodyValidation } from "../../../src/validation/userValidation.ts";
const validPassword = "OldPass1!";
const validNewPassword = "NewPass1!";
describe("editUserBodyValidation", () => {
// Regression: the Joi->Zod validation refactor (commit c3a41272a3) dropped
// `password`/`newPassword` from this schema. Because z.object() strips
// unknown keys, the change-password flow in userService.editUser silently
// became a no-op. Both fields must survive parsing.
it("retains password and newPassword on the parsed body", () => {
const result = editUserBodyValidation.safeParse({
password: validPassword,
newPassword: validNewPassword,
});
expect(result.success).toBe(true);
expect(result.data).toEqual({
password: validPassword,
newPassword: validNewPassword,
});
});
it("accepts a profile-only edit with neither password field", () => {
const result = editUserBodyValidation.safeParse({ firstName: "Ada", lastName: "Lovelace" });
expect(result.success).toBe(true);
});
it("rejects password without newPassword", () => {
const result = editUserBodyValidation.safeParse({ password: validPassword });
expect(result.success).toBe(false);
});
it("rejects newPassword without password", () => {
const result = editUserBodyValidation.safeParse({ newPassword: validNewPassword });
expect(result.success).toBe(false);
});
it("rejects a newPassword that does not meet the strength policy", () => {
const result = editUserBodyValidation.safeParse({
password: validPassword,
newPassword: "weak",
});
expect(result.success).toBe(false);
});
});