update tests

server/test/integration/monitorRepository.test.ts

@@ -31,6 +31,23 @@ const seedMonitor = (teamId: mongoose.Types.ObjectId, name: string, tags: mongoo
 		tags,
 	});
 
+const makeSnapshot = (id: string, dayOfMonth: number) => ({
+	id,
+	status: true,
+	responseTime: 100,
+	createdAt: new Date(2026, 7, dayOfMonth),
+});
+
+const seedMonitorWithChecks = (teamId: mongoose.Types.ObjectId, name: string, type: string, snapshotIds: string[]) =>
+	MonitorModel.create({
+		userId: new mongoose.Types.ObjectId(),
+		teamId,
+		name,
+		type,
+		url: "https://example.com",
+		recentChecks: snapshotIds.map((id, i) => makeSnapshot(id, i + 1)),
+	});
+
 describe("MongoMonitorsRepository", () => {
 	describe("tag filtering", () => {
 		it("matches ObjectId tag references when filters arrive as query strings", async () => {
@@ -51,4 +68,59 @@ describe("MongoMonitorsRepository", () => {
 			expect(summary.totalMonitors).toBe(1);
 		});
 	});
+
+	describe("findByIds recentChecks modes", () => {
+		const seedFixtures = async () => {
+			const teamId = new mongoose.Types.ObjectId();
+			const hardware = await seedMonitorWithChecks(teamId, "hw", "hardware", ["hw-1", "hw-2", "hw-3"]);
+			const http = await seedMonitorWithChecks(teamId, "web", "http", ["web-1", "web-2"]);
+			return { ids: [hardware._id.toString(), http._id.toString()] };
+		};
+
+		const checksByName = (monitors: Awaited<ReturnType<MongoMonitorsRepository["findByIds"]>>) =>
+			Object.fromEntries(monitors.map((monitor) => [monitor.name, monitor.recentChecks.map((check) => check.id)]));
+
+		it("returns full recentChecks by default and for mode 'all'", async () => {
+			const repo = new MongoMonitorsRepository();
+			const { ids } = await seedFixtures();
+
+			const byDefault = await repo.findByIds(ids);
+			const byAll = await repo.findByIds(ids, { recentChecks: "all" });
+
+			for (const monitors of [byDefault, byAll]) {
+				expect(checksByName(monitors)).toEqual({ hw: ["hw-1", "hw-2", "hw-3"], web: ["web-1", "web-2"] });
+			}
+		});
+
+		it("strips recentChecks for mode 'none'", async () => {
+			const repo = new MongoMonitorsRepository();
+			const { ids } = await seedFixtures();
+
+			const monitors = await repo.findByIds(ids, { recentChecks: "none" });
+
+			expect(checksByName(monitors)).toEqual({ hw: [], web: [] });
+		});
+
+		it("keeps only the newest snapshot for hardware monitors in 'latestHardware' mode", async () => {
+			const repo = new MongoMonitorsRepository();
+			const { ids } = await seedFixtures();
+
+			const monitors = await repo.findByIds(ids, { recentChecks: "latestHardware" });
+
+			expect(checksByName(monitors)).toEqual({ hw: ["hw-3"], web: [] });
+		});
+
+		it("returns an empty array in 'latestHardware' mode for a hardware monitor with no recentChecks field at all", async () => {
+			const repo = new MongoMonitorsRepository();
+			const teamId = new mongoose.Types.ObjectId();
+			const hardware = await seedMonitorWithChecks(teamId, "hw-fresh", "hardware", []);
+			// $slice on a missing operand is a hard aggregation error; the $ifNull guard must cover it
+			await MonitorModel.updateOne({ _id: hardware._id }, { $unset: { recentChecks: 1 } });
+
+			const monitors = await repo.findByIds([hardware._id.toString()], { recentChecks: "latestHardware" });
+
+			expect(monitors).toHaveLength(1);
+			expect(monitors[0].recentChecks).toEqual([]);
+		});
+	});
 });