From 85c3a16f411e5a94d3662a971f22e0488855f79d Mon Sep 17 00:00:00 2001
From: Vishnu Sreekumaran Nair <200557136@student.georgianc.on.ca>
Date: Tue, 6 May 2025 16:45:48 -0400
Subject: [PATCH] add pagespeed to intialstate and handler in settingsslice

---
 client/src/Features/Settings/settingsSlice.js |  2 ++
 server/service/settingsService.js             | 13 +++++--------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/client/src/Features/Settings/settingsSlice.js b/client/src/Features/Settings/settingsSlice.js
index 51f85a2b5..35e17e360 100644
--- a/client/src/Features/Settings/settingsSlice.js
+++ b/client/src/Features/Settings/settingsSlice.js
@@ -6,6 +6,7 @@ const initialState = {
 	apiBaseUrl: "",
 	logLevel: "debug",
 	language: "",
+	pagespeedApiKey: "",
 };
 
 export const getAppSettings = createAsyncThunk(
@@ -57,6 +58,7 @@ const handleGetSettingsFulfilled = (state, action) => {
 	state.apiBaseUrl = action.payload.data.apiBaseUrl;
 	state.logLevel = action.payload.data.logLevel;
 	state.language = action.payload.data.language;
+	state.pagespeedApiKey = action.payload.data.pagespeedApiKey;
 };
 const handleGetSettingsRejected = (state, action) => {
 	state.isLoading = false;
diff --git a/server/service/settingsService.js b/server/service/settingsService.js
index 7a219a89d..1443755f9 100755
--- a/server/service/settingsService.js
+++ b/server/service/settingsService.js
@@ -48,14 +48,11 @@ class SettingsService {
 
 			// If there are any settings that weren't set by environment variables, use user settings from DB
 			for (const key in envConfig) {
-
-				const envValue = envConfig[key];
-				const dbValue = dbSettings?.[key];
-
-				if (envValue === undefined || envValue === "") {
-					if (dbValue !== undefined) {
-						this.settings[key] = dbValue;
-					}
+				if (
+					typeof envConfig?.[key] === "undefined" &&
+					typeof dbSettings?.[key] !== "undefined"
+				) {
+					this.settings[key] = dbSettings[key];
 				}
 			}