From 8605b068ce8b366eb8d418495f1f7dd1507fd739 Mon Sep 17 00:00:00 2001 From: Alex Holliday Date: Tue, 5 Nov 2024 13:36:31 +0800 Subject: [PATCH] Refactor for robustness --- Server/db/mongo/modules/monitorModule.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Server/db/mongo/modules/monitorModule.js b/Server/db/mongo/modules/monitorModule.js index 57497485d..9f009b451 100644 --- a/Server/db/mongo/modules/monitorModule.js +++ b/Server/db/mongo/modules/monitorModule.js @@ -107,10 +107,15 @@ const getAverageResponseTime = (checks) => { if (!checks || checks.length === 0) { return 0; } - const aggResponseTime = checks.reduce((sum, check) => { + + const validChecks = checks.filter((check) => typeof check.responseTime === "number"); + if (validChecks.length === 0) { + return 0; + } + const aggResponseTime = validChecks.reduce((sum, check) => { return sum + check.responseTime; }, 0); - return aggResponseTime / checks.length; + return aggResponseTime / validChecks.length; }; /**