add tests

This commit is contained in:
Alex Holliday committed 2026-08-17 12:58:56 -07:00
1 parent ab7f2cd8f4
commit 9001a8d294
3 files changed
+218 -4

No files matched your search

@@ -3,6 +3,8 @@ import { StatusPageService } from "../../../src/domain/status-pages/status-page.
import type { IStatusPagesRepository } from "../../../src/domain/status-pages/status-page-repository.interface.ts";
import type { ISettingsService } from "../../../src/domain/app-settings/app-settings.service.ts";
import type { IMonitorsRepository } from "../../../src/domain/monitors/monitor.repository.interface.ts";
import type { IChecksRepository } from "../../../src/domain/checks/check.repository.interface.ts";
import type { CheckSnapshot } from "../../../src/domain/checks/check.type.ts";
import type { Monitor } from "../../../src/domain/monitors/monitor.type.ts";
import type { StatusPage } from "../../../src/domain/status-pages/status-page.type.ts";
import { DEFAULT_STATUS_PAGE_THEME, DEFAULT_STATUS_PAGE_THEME_MODE } from "../../../src/domain/status-pages/status-page.type.ts";
@@ -69,7 +71,7 @@ const createSettingsService = (themesEnabled: boolean, clientHost = "http://loca
({
areStatusPageThemesEnabled: jest.fn().mockReturnValue(themesEnabled),
getSettings: jest.fn().mockReturnValue({ clientHost }),
getDBSettings: jest.fn().mockResolvedValue({ showURL }),
getDBSettings: jest.fn().mockResolvedValue({ showURL, checkTTL: 30 }),
}) as unknown as jest.Mocked<ISettingsService>;
const createMonitorsRepo = () =>
@@ -77,12 +79,18 @@ const createMonitorsRepo = () =>
findByIds: jest.fn().mockResolvedValue([makeMonitor()]),
}) as unknown as jest.Mocked<IMonitorsRepository>;
const createChecksRepo = () =>
({
getDailyStatusBuckets: jest.fn().mockResolvedValue([]),
}) as unknown as jest.Mocked<IChecksRepository>;
const createService = (themesEnabled = true, clientHost = "http://localhost:5173", showURL = false) => {
const repo = createRepo();
const settingsService = createSettingsService(themesEnabled, clientHost, showURL);
const monitorsRepo = createMonitorsRepo();
const service = new StatusPageService(repo, settingsService, monitorsRepo);
return { service, repo, settingsService, monitorsRepo };
const checksRepo = createChecksRepo();
const service = new StatusPageService(repo, settingsService, monitorsRepo, checksRepo);
return { service, repo, settingsService, monitorsRepo, checksRepo };
};
// ── Tests ────────────────────────────────────────────────────────────────────
@@ -353,6 +361,59 @@ describe("StatusPageService", () => {
statusPage: expect.objectContaining({ id: "sp-1" }),
});
});
describe("range", () => {
it("omits range-mode fields and never queries buckets for the default (latest) range", async () => {
const { service, checksRepo } = createService();
const implicitLatest = await service.getPublicStatusPagePayload(publishedPage(), undefined);
const explicitLatest = await service.getPublicStatusPagePayload(publishedPage(), undefined, "latest");
for (const payload of [implicitLatest, explicitLatest]) {
expect(payload).not.toHaveProperty("range");
expect(payload).not.toHaveProperty("bucketTimezone");
expect(payload).not.toHaveProperty("checkTTLDays");
expect(payload.monitors[0]).not.toHaveProperty("dailyChecks");
}
expect(checksRepo.getDailyStatusBuckets).not.toHaveBeenCalled();
});
it("attaches dailyChecks, empties recentChecks, and echoes range metadata for a day range", async () => {
const { service, checksRepo, monitorsRepo } = createService();
const bucket = { monitorId: "mon-1", date: "2026-08-01", totalChecks: 10, upChecks: 9, downChecks: 1, avgResponseTime: 120 };
(checksRepo.getDailyStatusBuckets as jest.Mock).mockResolvedValue([bucket]);
(monitorsRepo.findByIds as jest.Mock).mockResolvedValue([makeMonitor({ recentChecks: [{ id: "chk-1" } as CheckSnapshot] })]);
const page = makeStatusPage({ isPublished: true, timezone: "America/Toronto" });
const payload = await service.getPublicStatusPagePayload(page, undefined, "30d");
expect(checksRepo.getDailyStatusBuckets).toHaveBeenCalledWith(["mon-1"], 30, "America/Toronto");
expect(payload).toMatchObject({ range: "30d", bucketTimezone: "America/Toronto", checkTTLDays: 30 });
expect(payload.monitors[0].recentChecks).toEqual([]);
expect(payload.monitors[0].dailyChecks).toEqual([bucket]);
for (const field of SENSITIVE_FIELDS) {
expect(payload.monitors[0]).not.toHaveProperty(field);
}
});
it("falls back to Etc/UTC when the page has no timezone and defaults dailyChecks to empty", async () => {
const { service, checksRepo } = createService();
const payload = await service.getPublicStatusPagePayload(publishedPage(), undefined, "60d");
expect(checksRepo.getDailyStatusBuckets).toHaveBeenCalledWith(["mon-1"], 60, "Etc/UTC");
expect(payload.bucketTimezone).toBe("Etc/UTC");
expect(payload.monitors[0].dailyChecks).toEqual([]);
});
it("does not bypass the unpublished-page 403", async () => {
const { service, checksRepo } = createService();
const unpublished = makeStatusPage({ isPublished: false, teamId: "team-A" });
await expect(service.getPublicStatusPagePayload(unpublished, undefined, "90d")).rejects.toMatchObject({ status: 403 });
expect(checksRepo.getDailyStatusBuckets).not.toHaveBeenCalled();
});
});
});
describe("deleteStatusPage", () => {
@@ -1,5 +1,6 @@
import { describe, expect, it } from "@jest/globals";
import { createStatusPageBodyValidation } from "../../../src/api/validation/statusPageValidation.ts";
import { createStatusPageBodyValidation, getStatusPageQueryValidation } from "../../../src/api/validation/statusPageValidation.ts";
import { StatusPageRanges } from "../../../src/domain/status-pages/status-page.type.ts";
const baseCreateBody = (overrides: Record<string, unknown> = {}) => ({
type: "uptime",
@@ -61,3 +62,31 @@ describe("createStatusPageBodyValidation", () => {
}
});
});
describe("getStatusPageQueryValidation", () => {
it("defaults range to latest when absent", () => {
const result = getStatusPageQueryValidation.safeParse({ type: "uptime" });
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.range).toBe("latest");
}
});
it("accepts every supported range", () => {
for (const range of StatusPageRanges) {
const result = getStatusPageQueryValidation.safeParse({ type: "uptime", range });
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.range).toBe(range);
}
}
});
it("rejects an unsupported range", () => {
const result = getStatusPageQueryValidation.safeParse({ type: "uptime", range: "45d" });
expect(result.success).toBe(false);
if (!result.success) {
expect(result.error.issues).toEqual(expect.arrayContaining([expect.objectContaining({ path: ["range"] })]));
}
});
});