fix: rename "breached" to "threshold exceeded" in user-facing strings

Only changes user-facing text — no enum, type, or backend status changes.

## Changes
- locales/en.json: "breached" → "threshold exceeded"
- notificationMessageBuilder.ts: notification title/summary/details
- email.ts: email subject line
This commit is contained in:
gorkem-bwl committed 2026-03-11 16:30:30 -04:00
1 parent 943ef92053
commit 9466090332
13 files changed
+32 -59

No files matched your search

@@ -1,25 +0,0 @@
import { MonitorModel } from "../models/Monitor.js";
import { logger } from "@/utils/logger.js";
/**
* Rename monitor status "breached" to "exceeded" for clarity.
* The word "breached" was confusing users as it implied a security breach.
*/
export async function renameBreachedToExceeded(): Promise<void> {
const SERVICE_NAME = "Migration:RenameBreachedToExceeded";
try {
logger.info({ service: SERVICE_NAME, message: "Starting status rename: breached -> exceeded" });
const result = await MonitorModel.updateMany({ status: "breached" }, { $set: { status: "exceeded" } });
logger.info({
service: SERVICE_NAME,
message: `Updated ${result.modifiedCount} monitors from 'breached' to 'exceeded'`,
});
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error);
logger.error({ service: SERVICE_NAME, message: `Error renaming status: ${errorMessage}` });
throw error;
}
}
-2
View File
@@ -2,7 +2,6 @@ import { migrateStatusWindowThreshold } from "./0001_migrateStatusWindowThreshol
import { convertChecksToTimeSeries } from "./0002_convertChecksToTimeSeries.js";
import { cleanupDuplicateMonitorStats } from "./0003_cleanupDuplicateMonitorStats.js";
import { fixInfrastructureThresholds } from "./0004_fixInfrastructureThresholds.js";
import { renameBreachedToExceeded } from "./0005_renameBreachedToExceeded.js";
import MigrationModel from "../models/Migration.js";
type MigrationEntry = {
@@ -15,7 +14,6 @@ const migrations: MigrationEntry[] = [
{ name: "0002_convertChecksToTimeSeries", execute: convertChecksToTimeSeries },
{ name: "0003_cleanupDuplicateMonitorStats", execute: cleanupDuplicateMonitorStats },
{ name: "0004_fixInfrastructureThresholds", execute: fixInfrastructureThresholds },
{ name: "0005_renameBreachedToExceeded", execute: renameBreachedToExceeded },
];
const runMigrations = async (logger?: { info: Function; error: Function }) => {
@@ -262,9 +262,9 @@ class MongoMonitorsRepository implements IMonitorsRepository {
$cond: [{ $eq: ["$status", "maintenance"] }, 1, 0],
},
},
exceededMonitors: {
breachedMonitors: {
$sum: {
$cond: [{ $eq: ["$status", "exceeded"] }, 1, 0],
$cond: [{ $eq: ["$status", "breached"] }, 1, 0],
},
},
},
@@ -281,7 +281,7 @@ class MongoMonitorsRepository implements IMonitorsRepository {
pausedMonitors: 0,
initializingMonitors: 0,
maintenanceMonitors: 0,
exceededMonitors: 0,
breachedMonitors: 0,
}
);
};
@@ -440,14 +440,14 @@ export class SuperSimpleQueueHelper implements ISuperSimpleQueueHelper {
decision.shouldSendNotification = true;
decision.incidentReason = "status_down";
decision.notificationReason = "status_change";
} else if (monitor.status === "exceeded") {
} else if (monitor.status === "breached") {
// Hardware monitor exceeded thresholds
decision.shouldCreateIncident = true;
decision.shouldSendNotification = true;
decision.incidentReason = "threshold_breach";
decision.notificationReason = "threshold_breach";
} else if (monitor.status === "up" && (prevStatus === "down" || prevStatus === "exceeded")) {
// Monitor recovered from down or exceeded state
} else if (monitor.status === "up" && (prevStatus === "down" || prevStatus === "breached")) {
// Monitor recovered from down or breached state
decision.shouldResolveIncident = true;
decision.shouldSendNotification = true;
decision.notificationReason = "status_change";
@@ -292,7 +292,7 @@ export class StatusService implements IStatusService {
temp: tempBreach,
};
// Update counters: decrement if exceeded, reset to 5 if not exceeded
// Update counters: decrement if breached, reset to 5 if not breached
if (cpuBreach) {
monitor.cpuAlertCounter = Math.max(0, monitor.cpuAlertCounter - 1);
} else {
@@ -321,23 +321,23 @@ export class StatusService implements IStatusService {
const anyCounterZero =
monitor.cpuAlertCounter === 0 || monitor.memoryAlertCounter === 0 || monitor.diskAlertCounter === 0 || monitor.tempAlertCounter === 0;
const anyThresholdExceeded = cpuBreach || memoryBreach || diskBreach || tempBreach;
const anyThresholdBreached = cpuBreach || memoryBreach || diskBreach || tempBreach;
const allThresholdsNormal = !cpuBreach && !memoryBreach && !diskBreach && !tempBreach;
// Update monitor status based on threshold exceeded state
// Update monitor status based on threshold breach state
if (newStatus !== "down") {
// Don't override "down" status - service unreachable takes precedence
// Check current monitor status, not newStatus for comparison
if (anyCounterZero && anyThresholdExceeded && monitor.status !== "exceeded") {
// Threshold exceeded: counter hit zero, change status to exceeded
newStatus = "exceeded";
if (anyCounterZero && anyThresholdBreached && monitor.status !== "breached") {
// Initial breach: counter hit zero, change status to breached
newStatus = "breached";
statusChanged = true;
} else if (anyCounterZero && anyThresholdExceeded && monitor.status === "exceeded") {
// Already exceeded, keep status but don't mark as changed
newStatus = "exceeded";
} else if (anyCounterZero && anyThresholdBreached && monitor.status === "breached") {
// Already breached, keep status but don't mark as changed
newStatus = "breached";
// statusChanged remains false
} else if (allThresholdsNormal && monitor.status === "exceeded") {
// All thresholds returned to normal, recover from exceeded state
} else if (allThresholdsNormal && monitor.status === "breached") {
// All thresholds returned to normal, recover from breached state
newStatus = "up";
statusChanged = true;
}
+2 -2
View File
@@ -9,7 +9,7 @@ export type MonitorType = (typeof MonitorTypes)[number];
export const GeoCheckSupportedTypes: readonly MonitorType[] = ["http", "ping"] as const;
export const supportsGeoCheck = (type: MonitorType): boolean => GeoCheckSupportedTypes.includes(type);
export const MonitorStatuses = ["up", "down", "paused", "initializing", "maintenance", "exceeded"] as const;
export const MonitorStatuses = ["up", "down", "paused", "initializing", "maintenance", "breached"] as const;
export type MonitorStatus = (typeof MonitorStatuses)[number];
export type MonitorMatchMethod = "equal" | "include" | "regex" | "";
@@ -64,7 +64,7 @@ export interface MonitorsSummary {
pausedMonitors: number;
initializingMonitors: number;
maintenanceMonitors: number;
exceededMonitors: number;
breachedMonitors: number;
}
export interface MonitorsWithChecksByTeamIdResult {