From 9f1deb64d76d44113a0ecfdbc924d2a01362b2e7 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Fri, 11 Oct 2024 14:01:19 +0800
Subject: [PATCH] Add tests for deleteMaintenanceWindow

---
 .../maintenanceWindowController.js            |  2 +-
 .../maintenanceWindowController.test.js       | 55 +++++++++++++++++++
 2 files changed, 56 insertions(+), 1 deletion(-)

diff --git a/Server/controllers/maintenanceWindowController.js b/Server/controllers/maintenanceWindowController.js
index cbc50271d..933da41ea 100644
--- a/Server/controllers/maintenanceWindowController.js
+++ b/Server/controllers/maintenanceWindowController.js
@@ -128,7 +128,7 @@ const deleteMaintenanceWindow = async (req, res, next) => {
   }
   try {
     await req.db.deleteMaintenanceWindowById(req.params.id);
-    return res.status(201).json({
+    return res.status(200).json({
       success: true,
       msg: successMessages.MAINTENANCE_WINDOW_DELETE,
     });
diff --git a/Server/tests/controllers/maintenanceWindowController.test.js b/Server/tests/controllers/maintenanceWindowController.test.js
index 161d380ba..4e7ce516c 100644
--- a/Server/tests/controllers/maintenanceWindowController.test.js
+++ b/Server/tests/controllers/maintenanceWindowController.test.js
@@ -266,3 +266,58 @@ describe("maintenanceWindowController - getMaintenanceWindowsByMonitorId", () =>
     ).to.be.true;
   });
 });
+
+describe("maintenanceWindowController - deleteMaintenanceWindow", () => {
+  beforeEach(() => {
+    req = {
+      body: {},
+      params: {
+        id: "123",
+      },
+      query: {},
+      headers: {
+        authorization: "Bearer token",
+      },
+      settingsService: {
+        getSettings: sinon.stub().returns({ jwtSecret: "jwtSecret" }),
+      },
+      db: {
+        deleteMaintenanceWindowById: sinon.stub(),
+      },
+    };
+    res = {
+      status: sinon.stub().returnsThis(),
+      json: sinon.stub(),
+    };
+    next = sinon.stub();
+  });
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  it("should reject if param validation fails", async () => {
+    req.params = {};
+    await deleteMaintenanceWindow(req, res, next);
+    expect(next.firstCall.args[0]).to.be.an("error");
+    expect(next.firstCall.args[0].status).to.equal(422);
+  });
+
+  it("should reject with an error if DB operations fail", async () => {
+    req.db.deleteMaintenanceWindowById.throws(new Error("DB error"));
+    await deleteMaintenanceWindow(req, res, next);
+    expect(next.firstCall.args[0]).to.be.an("error");
+    expect(next.firstCall.args[0].message).to.equal("DB error");
+  });
+
+  it("should return success message if all operations are successful", async () => {
+    await deleteMaintenanceWindow(req, res, next);
+    expect(req.db.deleteMaintenanceWindowById.calledOnceWith(req.params.id));
+    expect(res.status.firstCall.args[0]).to.equal(200);
+    expect(
+      res.json.calledOnceWith({
+        success: true,
+        msg: successMessages.MAINTENANCE_WINDOW_DELETE,
+      })
+    ).to.be.true;
+  });
+});