From a1b10c7469ff81428a11f486f9010673399ecb5c Mon Sep 17 00:00:00 2001 From: Alex Holliday Date: Wed, 23 Sep 2026 13:51:30 -0700 Subject: [PATCH] remove unused param --- server/src/domain/incidents/incident.service.ts | 6 +++--- server/src/worker/reactors/reactor.incident.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/src/domain/incidents/incident.service.ts b/server/src/domain/incidents/incident.service.ts index e77fa5498..c4208aafb 100644 --- a/server/src/domain/incidents/incident.service.ts +++ b/server/src/domain/incidents/incident.service.ts @@ -15,7 +15,7 @@ import { DateRange } from "@/types/query.js"; import { describeContainerBreach, findContainerBreaches } from "@/domain/docker/docker-alert.js"; export interface IIncidentService { - handleIncident(monitor: Monitor, code: number, decision: MonitorActionDecision, check: Check): Promise; + handleIncident(monitor: Monitor, decision: MonitorActionDecision, check: Check): Promise; resolveIncident(incidentId: string, userId: string, teamId: string, comment?: string, userEmail?: string): Promise; getIncidentsByTeam( teamId: string, @@ -54,7 +54,7 @@ export class IncidentService implements IIncidentService { this.notificationMessageBuilder = notificationMessageBuilder; } - handleIncident = async (monitor: Monitor, code: number, decision: MonitorActionDecision, check: Check): Promise => { + handleIncident = async (monitor: Monitor, decision: MonitorActionDecision, check: Check): Promise => { if (!decision.shouldCreateIncident && !decision.shouldResolveIncident) { return null; } @@ -65,7 +65,7 @@ export class IncidentService implements IIncidentService { if (activeIncident) { return activeIncident; } else { - let statusCode = code; + let statusCode = check.statusCode; let message: string | undefined; // For threshold breaches, use 9999 status code and build descriptive message diff --git a/server/src/worker/reactors/reactor.incident.ts b/server/src/worker/reactors/reactor.incident.ts index 24ca60e7b..390be7fd8 100644 --- a/server/src/worker/reactors/reactor.incident.ts +++ b/server/src/worker/reactors/reactor.incident.ts @@ -8,6 +8,6 @@ export class IncidentReactor implements IMonitorReactor { constructor(private incidentService: IIncidentService) {} react = async (evaluation: MonitorEvaluation) => { - await this.incidentService.handleIncident(evaluation.monitor, evaluation.statusChange.code, evaluation.decision, evaluation.check); + await this.incidentService.handleIncident(evaluation.monitor, evaluation.decision, evaluation.check); }; }