From 61cc0c2befe9cf3fa74545f486760562deb94958 Mon Sep 17 00:00:00 2001 From: Alex Holliday Date: Wed, 11 Mar 2026 13:51:37 -0700 Subject: [PATCH 1/2] remove unused route --- server/src/controllers/queueController.ts | 18 +++--------------- server/src/routes/queueRoute.ts | 1 - .../SuperSimpleQueue/SuperSimpleQueue.ts | 2 +- 3 files changed, 4 insertions(+), 17 deletions(-) diff --git a/server/src/controllers/queueController.ts b/server/src/controllers/queueController.ts index 9885bab87..5076e0b60 100755 --- a/server/src/controllers/queueController.ts +++ b/server/src/controllers/queueController.ts @@ -1,11 +1,12 @@ +import { ISuperSimpleQueue } from "@/service/index.js"; import { Request, Response, NextFunction } from "express"; const SERVICE_NAME = "JobQueueController"; class JobQueueController { static SERVICE_NAME = SERVICE_NAME; - private jobQueue: any; - constructor(jobQueue: any) { + private jobQueue: ISuperSimpleQueue; + constructor(jobQueue: ISuperSimpleQueue) { this.jobQueue = jobQueue; } @@ -77,18 +78,5 @@ class JobQueueController { next(error); } }; - - checkQueueHealth = async (req: Request, res: Response, next: NextFunction) => { - try { - const stuckQueues = await this.jobQueue.checkQueueHealth(); - return res.status(200).json({ - success: true, - msg: "Queue health checked successfully", - data: stuckQueues, - }); - } catch (error) { - next(error); - } - }; } export default JobQueueController; diff --git a/server/src/routes/queueRoute.ts b/server/src/routes/queueRoute.ts index d5b036b15..80346d48c 100755 --- a/server/src/routes/queueRoute.ts +++ b/server/src/routes/queueRoute.ts @@ -14,7 +14,6 @@ class QueueRoutes { this.router.post("/jobs", isAllowed(["admin", "superadmin"]), this.queueController.addJob); this.router.get("/metrics", isAllowed(["admin", "superadmin"]), this.queueController.getMetrics); - this.router.get("/health", isAllowed(["admin", "superadmin"]), this.queueController.checkQueueHealth); this.router.get("/all-metrics", isAllowed(["admin", "superadmin"]), this.queueController.getAllMetrics); this.router.post("/flush", isAllowed(["admin", "superadmin"]), this.queueController.flushQueue); } diff --git a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts index f4fd5b1e6..151c41e5c 100644 --- a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts +++ b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts @@ -42,7 +42,7 @@ type QueueJobSummary = { export interface ISuperSimpleQueue { readonly serviceName: string; init(): Promise; - addJob(monitorId: string, monitor: Monitor): Promise; + addJob(monitorId: string, monitor?: Monitor): Promise; deleteJob(monitor: Monitor): Promise; pauseJob(monitor: Monitor): Promise; resumeJob(monitor: Monitor): Promise; From 1af609a5693b3c5b467839b9b3e27d3ba09de17b Mon Sep 17 00:00:00 2001 From: Alex Holliday Date: Wed, 11 Mar 2026 14:08:20 -0700 Subject: [PATCH 2/2] remove unsued route/methods --- server/src/controllers/queueController.ts | 12 ------------ server/src/routes/queueRoute.ts | 1 - .../SuperSimpleQueue/SuperSimpleQueue.ts | 2 +- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/server/src/controllers/queueController.ts b/server/src/controllers/queueController.ts index 5076e0b60..9ae2b494a 100755 --- a/server/src/controllers/queueController.ts +++ b/server/src/controllers/queueController.ts @@ -54,18 +54,6 @@ class JobQueueController { } }; - addJob = async (req: Request, res: Response, next: NextFunction) => { - try { - await this.jobQueue.addJob(Math.random().toString(36).substring(7)); - return res.status(200).json({ - success: true, - msg: "Job added to queue successfully", - }); - } catch (error) { - next(error); - } - }; - flushQueue = async (req: Request, res: Response, next: NextFunction) => { try { const result = await this.jobQueue.flushQueues(); diff --git a/server/src/routes/queueRoute.ts b/server/src/routes/queueRoute.ts index 80346d48c..dd3b27999 100755 --- a/server/src/routes/queueRoute.ts +++ b/server/src/routes/queueRoute.ts @@ -11,7 +11,6 @@ class QueueRoutes { } initRoutes() { this.router.get("/jobs", isAllowed(["admin", "superadmin"]), this.queueController.getJobs); - this.router.post("/jobs", isAllowed(["admin", "superadmin"]), this.queueController.addJob); this.router.get("/metrics", isAllowed(["admin", "superadmin"]), this.queueController.getMetrics); this.router.get("/all-metrics", isAllowed(["admin", "superadmin"]), this.queueController.getAllMetrics); diff --git a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts index 151c41e5c..f4fd5b1e6 100644 --- a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts +++ b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueue.ts @@ -42,7 +42,7 @@ type QueueJobSummary = { export interface ISuperSimpleQueue { readonly serviceName: string; init(): Promise; - addJob(monitorId: string, monitor?: Monitor): Promise; + addJob(monitorId: string, monitor: Monitor): Promise; deleteJob(monitor: Monitor): Promise; pauseJob(monitor: Monitor): Promise; resumeJob(monitor: Monitor): Promise;