diff --git a/server/src/controllers/inviteController.ts b/server/src/controllers/inviteController.ts index 664d84d98..990b81651 100755 --- a/server/src/controllers/inviteController.ts +++ b/server/src/controllers/inviteController.ts @@ -1,5 +1,6 @@ import { Request, Response, NextFunction } from "express"; import { inviteBodyValidation, inviteVerificationBodyValidation } from "@/validation/joi.js"; +import { requireTeamId, requireUserRoles } from "@/controllers/controllerUtils.js"; const SERVICE_NAME = "inviteController"; class InviteController { @@ -14,12 +15,14 @@ class InviteController { } getInviteToken = async (req: Request, res: Response, next: NextFunction) => { + console.log(req.body); try { + const teamId = requireTeamId(req.user?.teamId); + const userRoles = requireUserRoles(req.user?.role); const invite = req.body; - const teamId = req?.user?.teamId; invite.teamId = teamId; await inviteBodyValidation.validateAsync(invite); - const inviteToken = await this.inviteService.getInviteToken({ invite, teamId }); + const inviteToken = await this.inviteService.getInviteToken({ invite, teamId, userRoles }); return res.status(200).json({ success: true, msg: "Invite token generated successfully", diff --git a/server/src/service/business/inviteService.ts b/server/src/service/business/inviteService.ts index eee0f993c..ba6039b34 100644 --- a/server/src/service/business/inviteService.ts +++ b/server/src/service/business/inviteService.ts @@ -1,4 +1,5 @@ -import type { Invite } from "@/types/index.js"; +import type { Invite, UserRole } from "@/types/index.js"; +import { canManageRole } from "@/types/user.js"; import type { IInvitesRepository } from "@/repositories/index.js"; import { AppError } from "@/utils/AppError.js"; @@ -29,8 +30,23 @@ class InviteService { return InviteService.SERVICE_NAME; } - getInviteToken = async ({ invite, teamId }: { invite: Partial; teamId: string }) => { + getInviteToken = async ({ invite, teamId, userRoles }: { invite: Partial; teamId: string; userRoles: UserRole[] }) => { invite.teamId = teamId; + + const inviteRoles = invite.role ?? []; + + for (const targetRole of inviteRoles) { + const canManage = userRoles.some((actorRole) => canManageRole(actorRole, targetRole)); + if (!canManage) { + throw new AppError({ + message: "You do not have permission to create this invite", + service: SERVICE_NAME, + method: "getInviteToken", + status: 403, + }); + } + } + const inviteToken = await this.invitesRepository.create(invite); return inviteToken; };