Report whether the peer answered from every provider that can tell

An egress spell masked a service on the surviving network going down: with
`peerResponded` set only by the DNS and gRPC providers, every other failure fell
back to the HTTP-status heuristic, which answers "nothing replied" for anything
that is not speaking HTTP. A refused connection on the local network was read as
the instance's own loss of egress, so the check was recorded as degraded and the
monitor stayed up.

`peerAnsweredFromError` holds the errno codes that require the target's own stack
to have replied — a refusal, a reset, a TLS handshake that got as far as a
certificate. Http, Port, WebSocket and Docker use it; Http also treats any status
code as an answer, and Docker any status from the daemon. Hardware and PageSpeed
go through Http and inherit it.

`true` is the claim that costs something, since it blames the target, so it is
only set on evidence. Two cases stay conservative and are commented as such: a
ping that draws no echo reply, and a gamedig query that fails, neither of which
can be told apart from the instance losing its egress. Nor can a proxied HTTP
request that fails with no response, where the refusal may be the proxy's.

🔧
This commit is contained in:
Craig Lawson committed 2026-09-19 14:43:11 +01:00
1 parent 13799af721
commit b55560e2f1
13 files changed
+318 -7

No files matched your search

@@ -697,4 +697,43 @@ describe("DockerProvider", () => {
await expect(provider.handle(makeMonitor())).rejects.toThrow("Error performing Docker request");
});
});
// ── Peer reachability ────────────────────────────────────────────────────
// A daemon that answers with an error has been reached; only silence can be the instance's own egress.
describe("peer reachability", () => {
it("reports the peer as having answered when the daemon replies with a status code", async () => {
const dockerErr = Object.assign(new Error("base"), { statusCode: 500, json: { message: "engine exploded" } });
const { provider } = setup({ ping: jest.fn().mockRejectedValue(dockerErr) });
const result = await provider.handle(makeMonitor());
expect(result.status).toBe(false);
expect(result.peerResponded).toBe(true);
});
it.each([["ECONNREFUSED"], ["ECONNRESET"]])("reports the peer as having answered for %s", async (code) => {
const { provider } = setup({ ping: jest.fn().mockRejectedValue(Object.assign(new Error("connect failed"), { code })) });
const result = await provider.handle(makeMonitor());
expect(result.peerResponded).toBe(true);
});
it.each([["ETIMEDOUT"], ["EHOSTUNREACH"], ["ENOTFOUND"]])("reports the peer as silent for %s", async (code) => {
const { provider } = setup({ ping: jest.fn().mockRejectedValue(Object.assign(new Error("connect failed"), { code })) });
const result = await provider.handle(makeMonitor());
expect(result.peerResponded).toBe(false);
});
it("reports the peer as having answered when the daemon is reachable", async () => {
const { provider } = setup({});
const result = await provider.handle(makeMonitor());
expect(result.peerResponded).toBe(true);
});
});
});