From b75c1a4fcbeb481c04b1c81d71845ebf3a7a9632 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Sat, 14 Feb 2026 22:29:06 +0000
Subject: [PATCH] create incident on hardware breach

---
 .../SuperSimpleQueueHelper.ts                 | 22 +++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts
index 78e7d54d7..7e4c94586 100644
--- a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts
+++ b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts
@@ -218,10 +218,22 @@ class SuperSimpleQueueHelper {
 
 		// CASE 2: Hardware
 		if (!thresholdBreaches) {
-			return decision; // No breach data available
+			// No breach data available - still handle status changes
+			if (statusChanged && monitor.status === "down") {
+				decision.shouldCreateIncident = true;
+				decision.shouldSendNotification = true;
+				decision.incidentReason = "status_down";
+				decision.notificationReason = "status_change";
+			} else if (statusChanged && monitor.status === "up" && prevStatus === "down") {
+				decision.shouldResolveIncident = true;
+				decision.shouldSendNotification = true;
+				decision.notificationReason = "status_change";
+			}
+			return decision;
 		}
 
 		const anyThresholdBreached = Object.values(thresholdBreaches).some((b) => b);
+		const noThresholdsBreached = Object.values(thresholdBreaches).every((b) => !b);
 
 		// Check if countdown counter has reached zero for any breached threshold
 		const shouldNotifyThreshold =
@@ -233,6 +245,7 @@ class SuperSimpleQueueHelper {
 		// Decision logic for hardware
 		if (statusChanged && monitor.status === "down") {
 			// Hardware service is DOWN (unreachable)
+			// Status down takes precedence over threshold breaches
 			decision.shouldCreateIncident = true;
 			decision.shouldSendNotification = true;
 			decision.incidentReason = "status_down";
@@ -243,12 +256,17 @@ class SuperSimpleQueueHelper {
 			decision.shouldSendNotification = true;
 			decision.notificationReason = "status_change";
 		} else if (anyThresholdBreached && shouldNotifyThreshold) {
-			// Threshold breach alert (service is UP but metrics are high)
+			// Threshold breach: Counters have reached zero
+			// Create incident if service is UP but metrics exceed thresholds
 			decision.shouldCreateIncident = true;
 			decision.shouldSendNotification = true;
 			decision.incidentReason = "threshold_breach";
 			decision.notificationReason = "threshold_breach";
 			decision.thresholdBreaches = thresholdBreaches;
+		} else if (noThresholdsBreached && !anyThresholdBreached) {
+			// All thresholds returned to normal - resolve any active threshold incidents
+			decision.shouldResolveIncident = true;
+			// Don't send notification for resolution (can be added later if needed)
 		}
 
 		return decision;