refactor(maintenance): tighten validator + migration per /simplify

- Collapse two refines into a single superRefine in createMaintenanceWindowBodyValidation; same on edit.
- Match peer migration convention: use mongoose.connection.db directly, not Model.collection.
- Tighten TTL index detection: require expireAfterSeconds + single-field key.
- Add Starting log at migration top to match peers 0003-0006.
This commit is contained in:
gorkem-bwl committed 2026-05-07 12:33:03 -04:00
1 parent 4db95cfa44
commit bd059da94a
2 files changed
+49 -20

No files matched your search

@@ -19,13 +19,23 @@ export const createMaintenanceWindowBodyValidation = z
repeat: z.number().min(0, "Repeat must be a non-negative number"),
})
.strict()
.refine((data) => new Date(data.end).getTime() > new Date(data.start).getTime(), {
message: "End must be after start",
path: ["end"],
})
.refine((data) => data.repeat > 0 || new Date(data.end).getTime() > Date.now(), {
message: "End must be in the future for one-time maintenance windows",
path: ["end"],
.superRefine((data, ctx) => {
const start = new Date(data.start).getTime();
const end = new Date(data.end).getTime();
if (end <= start) {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: "End must be after start",
path: ["end"],
});
}
if (data.repeat === 0 && end <= Date.now()) {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: "End must be in the future for one-time maintenance windows",
path: ["end"],
});
}
});
export const getMaintenanceWindowByIdParamValidation = z.object({
@@ -64,7 +74,16 @@ export const editMaintenanceByIdWindowBodyValidation = z
durationUnit: z.enum(["seconds", "minutes", "hours", "days"]).optional(),
})
.strict()
.refine((data) => !data.start || !data.end || new Date(data.end).getTime() > new Date(data.start).getTime(), {
message: "End must be after start",
path: ["end"],
.superRefine((data, ctx) => {
if (data.start && data.end) {
const start = new Date(data.start).getTime();
const end = new Date(data.end).getTime();
if (end <= start) {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: "End must be after start",
path: ["end"],
});
}
}
});