From c3d92ec812a6942bbefc51e0b41dd6ebbdcb5e34 Mon Sep 17 00:00:00 2001
From: dongfang <1136005348@qq.com>
Date: Wed, 12 Feb 2025 03:05:58 +0000
Subject: [PATCH] return early if not json

---
 Server/service/networkService.js | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Server/service/networkService.js b/Server/service/networkService.js
index 3a2bddb8a..741b69bef 100644
--- a/Server/service/networkService.js
+++ b/Server/service/networkService.js
@@ -1,5 +1,4 @@
 import jmespath from 'jmespath';
-import { errorMessages, successMessages } from "../utils/messages.js";
 const SERVICE_NAME = "NetworkService";
 const UPROCK_ENDPOINT = "https://api.uprock.com/checkmate/push";
 
@@ -171,19 +170,20 @@ class NetworkService {
 			if (jsonPath) {
 				const contentType = response.headers['content-type'];
 
-				if (contentType && contentType.includes('application/json')) {
-					try {
-						result = jmespath.search(result, jsonPath);
-					} catch (error) {
-						httpResponse.status = false;
-						httpResponse.message = "JSONPath Search Error";
-						return httpResponse;
-					}
-				} else {
+				const isJson = contentType?.includes('application/json');
+				if (!isJson) {
 					httpResponse.status = false;
 					httpResponse.message = "Response Not JSON";
 					return httpResponse;
 				}
+
+				try {
+					result = jmespath.search(result, jsonPath);
+				} catch (error) {
+					httpResponse.status = false;
+					httpResponse.message = "JSONPath Search Error";
+					return httpResponse;
+				}
 			}
 
 			if (result === null || result === undefined) {