Updated status codes, added edit monitor endpoint

This commit is contained in:
Alex Holliday committed 2024-05-21 13:52:28 -07:00
1 parent face3339cd
commit c4dc57b9be
6 files changed
+126 -63

No files matched your search

+48 -12
View File
@@ -1,7 +1,7 @@
const {
getMonitorByIdValidation,
getMonitorsByUserIdValidation,
createMonitorValidation,
monitorValidation,
} = require("../validation/joi");
const logger = require("../utils/logger");
@@ -37,7 +37,7 @@ const getMonitorById = async (req, res) => {
const { error } = getMonitorByIdValidation.validate(req.params);
if (error) {
return res
.status(400)
.status(422)
.json({ success: false, msg: error.details[0].message });
}
@@ -63,7 +63,7 @@ const getMonitorsByUserId = async (req, res) => {
const { error } = getMonitorsByUserIdValidation.validate(req.params);
if (error) {
return res
.status(400)
.status(422)
.json({ success: false, msg: error.details[0].message });
}
@@ -95,17 +95,17 @@ const getMonitorsByUserId = async (req, res) => {
*/
const createMonitor = async (req, res) => {
const { error } = createMonitorValidation.validate(req.body);
const { error } = monitorValidation.validate(req.body);
if (error) {
return res
.status(400)
.status(422)
.json({ success: false, msg: error.details[0].message });
}
try {
const monitor = await req.db.createMonitor(req, res);
return res
.status(200)
.status(201)
.json({ success: true, msg: "Monitor created", data: monitor });
} catch (error) {
logger.error(error.message, { service: "monitor" });
@@ -113,7 +113,6 @@ const createMonitor = async (req, res) => {
}
};
// Delete Monitor
/**
* Delete a monitor by ID
* @async
@@ -127,21 +126,57 @@ const deleteMonitor = async (req, res) => {
const { error } = getMonitorByIdValidation.validate(req.params);
if (error) {
return res
.status(400)
.status(422)
.json({ success: false, msg: error.details[0].message });
}
try {
const monitor = await req.db.deleteMonitor(req, res);
return res
.status(200)
.json({ success: true, msg: "Monitor deleted", data: monitor });
/**
* TODO
* We should remove all checks and alerts associated with this monitor
* when it is deleted so there is no orphaned data
* We also need to make sure to stop all running services for this monitor
*/
return res.status(204).json({ success: true, msg: "Monitor deleted" });
} catch (error) {
logger.error(error.message, { service: "monitor" });
return res.status(500).json({ success: false, msg: error.message });
}
};
// Edit Monitor
/**
* Edit a monitor by ID
* @async
* @param {Express.Request} req
* @param {Express.Response} res
* @returns {Promise<Express.Response>}
* @throws {Error}
*/
const editMonitor = async (req, res) => {
let paramError = getMonitorByIdValidation.validate(req.params);
if (paramError.error) {
return res
.status(422)
.json({ success: false, msg: paramError.error.details[0].message });
}
let { error } = monitorValidation.validate(req.body);
if (error) {
return res
.status(422)
.json({ success: false, msg: error.details[0].message });
}
try {
const editedMonitor = await req.db.editMonitor(req, res);
return res
.status(200)
.json({ success: true, msg: "Monitor edited", data: editedMonitor });
} catch (error) {
logger.error(error.message, { service: "monitor" });
return res.status(500).json({ success: false, msg: error.message });
}
};
module.exports = {
getAllMonitors,
@@ -149,4 +184,5 @@ module.exports = {
getMonitorsByUserId,
createMonitor,
deleteMonitor,
editMonitor,
};