From cd6f55a9c99a05eed4edbf76857a8b2ce218af19 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Tue, 27 Aug 2024 12:54:44 -0700
Subject: [PATCH] Conditionally render some components based on admin status

---
 Client/src/App.jsx                          | 10 +++-
 Client/src/Components/Fallback/index.jsx    | 19 +++---
 Client/src/HOC/withAdminProp.jsx            | 20 +++++++
 Client/src/Pages/Monitors/Details/index.jsx | 53 +++++++++--------
 Client/src/Pages/Monitors/index.jsx         | 65 ++++++++++++---------
 Client/src/Pages/PageSpeed/index.jsx        |  6 +-
 6 files changed, 110 insertions(+), 63 deletions(-)
 create mode 100644 Client/src/HOC/withAdminProp.jsx

diff --git a/Client/src/App.jsx b/Client/src/App.jsx
index 12db9dab9..f8a2f72f5 100644
--- a/Client/src/App.jsx
+++ b/Client/src/App.jsx
@@ -21,6 +21,7 @@ import ProtectedRoute from "./Components/ProtectedRoute";
 import Details from "./Pages/Monitors/Details";
 import Maintenance from "./Pages/Maintenance";
 import withAdminCheck from "./HOC/withAdminCheck";
+import withAdminProp from "./HOC/withAdminProp";
 import Configure from "./Pages/Monitors/Configure";
 import PageSpeed from "./Pages/PageSpeed";
 import CreatePageSpeed from "./Pages/PageSpeed/CreatePageSpeed";
@@ -30,6 +31,9 @@ import PageSpeedConfigure from "./Pages/PageSpeed/Configure";
 
 function App() {
   const AdminCheckedRegister = withAdminCheck(Register);
+  const MonitorsWithAdminProp = withAdminProp(Monitors);
+  const DetailsWithAdminProp = withAdminProp(Details);
+
   return (
     <>
       <Routes>
@@ -37,11 +41,11 @@ function App() {
           <Route
             exact
             path="/"
-            element={<ProtectedRoute Component={Monitors} />}
+            element={<ProtectedRoute Component={MonitorsWithAdminProp} />}
           />
           <Route
             path="/monitors"
-            element={<ProtectedRoute Component={Monitors} />}
+            element={<ProtectedRoute Component={MonitorsWithAdminProp} />}
           />
           <Route
             path="/monitors/create"
@@ -49,7 +53,7 @@ function App() {
           />
           <Route
             path="/monitors/:monitorId/"
-            element={<ProtectedRoute Component={Details} />}
+            element={<ProtectedRoute Component={DetailsWithAdminProp} />}
           />
           <Route
             path="/monitors/configure/:monitorId/"
diff --git a/Client/src/Components/Fallback/index.jsx b/Client/src/Components/Fallback/index.jsx
index 976440f7d..77b33e4b1 100644
--- a/Client/src/Components/Fallback/index.jsx
+++ b/Client/src/Components/Fallback/index.jsx
@@ -19,7 +19,7 @@ import "./index.css";
  * @returns {JSX.Element} The rendered fallback UI.
  */
 
-const Fallback = ({ title, checks, link = "/" }) => {
+const Fallback = ({ title, checks, link = "/", isAdmin }) => {
   const theme = useTheme();
   const navigate = useNavigate();
 
@@ -36,7 +36,7 @@ const Fallback = ({ title, checks, link = "/" }) => {
       />
       <Stack gap={theme.gap.small} maxWidth={"275px"} zIndex={1}>
         <Typography component="h1" marginY={theme.gap.medium}>
-          A {title} is used to:
+          A {title} monitor is used to:
         </Typography>
         {checks.map((check, index) => (
           <Check
@@ -46,12 +46,14 @@ const Fallback = ({ title, checks, link = "/" }) => {
           />
         ))}
       </Stack>
-      <Button
-        level="primary"
-        label={`Let's create your ${title}`}
-        sx={{ alignSelf: "center" }}
-        onClick={() => navigate(link)}
-      />
+      {isAdmin && (
+        <Button
+          level="primary"
+          label={`Let's create your ${title}`}
+          sx={{ alignSelf: "center" }}
+          onClick={() => navigate(link)}
+        />
+      )}
     </Stack>
   );
 };
@@ -60,6 +62,7 @@ Fallback.propTypes = {
   title: PropTypes.string.isRequired,
   checks: PropTypes.arrayOf(PropTypes.string).isRequired,
   link: PropTypes.string,
+  isAdmin: PropTypes.bool,
 };
 
 export default Fallback;
diff --git a/Client/src/HOC/withAdminProp.jsx b/Client/src/HOC/withAdminProp.jsx
new file mode 100644
index 000000000..6910ba5ea
--- /dev/null
+++ b/Client/src/HOC/withAdminProp.jsx
@@ -0,0 +1,20 @@
+import { useSelector } from "react-redux";
+
+const withAdminProp = (WrappedComponent) => {
+  const WithAdminProp = (props) => {
+    const { user } = useSelector((state) => state.auth);
+    const isAdmin =
+      (user?.role?.includes("admin") ?? false) ||
+      (user?.role?.includes("superadmin") ?? false);
+
+    return <WrappedComponent {...props} isAdmin={isAdmin} />;
+  };
+
+  const wrappedComponentName =
+    WrappedComponent.displayName || WrappedComponent.name || "Component";
+  WithAdminProp.displayName = `WithAdminProp(${wrappedComponentName})`;
+
+  return WithAdminProp;
+};
+
+export default withAdminProp;
diff --git a/Client/src/Pages/Monitors/Details/index.jsx b/Client/src/Pages/Monitors/Details/index.jsx
index 98904587e..019aa7845 100644
--- a/Client/src/Pages/Monitors/Details/index.jsx
+++ b/Client/src/Pages/Monitors/Details/index.jsx
@@ -110,7 +110,7 @@ const SkeletonLayout = () => {
  * Details page component displaying monitor details and related information.
  * @component
  */
-const DetailsPage = () => {
+const DetailsPage = ({ isAdmin }) => {
   const [monitor, setMonitor] = useState({});
   const { monitorId } = useParams();
   const { authToken } = useSelector((state) => state.auth);
@@ -196,29 +196,31 @@ const DetailsPage = () => {
                   Checking every {formatDurationRounded(monitor?.interval)}.
                 </Typography>
               </Box>
-              <Button
-                level="tertiary"
-                label="Configure"
-                animate="rotate90"
-                img={
-                  <SettingsIcon
-                    style={{
-                      minWidth: theme.gap.mlplus,
-                      minHeight: theme.gap.mlplus,
-                    }}
-                  />
-                }
-                onClick={() => navigate(`/monitors/configure/${monitorId}`)}
-                sx={{
-                  ml: "auto",
-                  alignSelf: "flex-end",
-                  backgroundColor: "#f4f4f4",
-                  px: theme.gap.medium,
-                  "& svg": {
-                    mr: "6px",
-                  },
-                }}
-              />
+              {isAdmin && (
+                <Button
+                  level="tertiary"
+                  label="Configure"
+                  animate="rotate90"
+                  img={
+                    <SettingsIcon
+                      style={{
+                        minWidth: theme.gap.mlplus,
+                        minHeight: theme.gap.mlplus,
+                      }}
+                    />
+                  }
+                  onClick={() => navigate(`/monitors/configure/${monitorId}`)}
+                  sx={{
+                    ml: "auto",
+                    alignSelf: "flex-end",
+                    backgroundColor: "#f4f4f4",
+                    px: theme.gap.medium,
+                    "& svg": {
+                      mr: "6px",
+                    },
+                  }}
+                />
+              )}
             </Stack>
             <Stack
               direction="row"
@@ -339,4 +341,7 @@ const DetailsPage = () => {
   );
 };
 
+DetailsPage.propTypes = {
+  isAdmin: PropTypes.bool,
+};
 export default DetailsPage;
diff --git a/Client/src/Pages/Monitors/index.jsx b/Client/src/Pages/Monitors/index.jsx
index 8f2b93531..bfcced973 100644
--- a/Client/src/Pages/Monitors/index.jsx
+++ b/Client/src/Pages/Monitors/index.jsx
@@ -28,13 +28,14 @@ import Settings from "../../assets/icons/settings-bold.svg?react";
 import PropTypes from "prop-types";
 import BarChart from "../../Components/Charts/BarChart";
 
-const ActionsMenu = ({ monitor }) => {
+const ActionsMenu = ({ monitor, isAdmin }) => {
   const [anchorEl, setAnchorEl] = useState(null);
   const [actions, setActions] = useState({});
   const [isOpen, setIsOpen] = useState(false);
   const dispatch = useDispatch();
   const theme = useTheme();
   const authState = useSelector((state) => state.auth);
+
   const handleRemove = async (event) => {
     event.preventDefault();
     event.stopPropagation();
@@ -119,23 +120,27 @@ const ActionsMenu = ({ monitor }) => {
         </MenuItem>
         {/* TODO - pass monitor id to Incidents page */}
         <MenuItem disabled>Incidents</MenuItem>
-        <MenuItem
-          onClick={(e) => {
-            e.stopPropagation();
+        {isAdmin && (
+          <MenuItem
+            onClick={(e) => {
+              e.stopPropagation();
 
-            navigate(`/monitors/configure/${actions.id}`);
-          }}
-        >
-          Configure
-        </MenuItem>
-        <MenuItem
-          onClick={(e) => {
-            e.stopPropagation();
-            openRemove(e);
-          }}
-        >
-          Remove
-        </MenuItem>
+              navigate(`/monitors/configure/${actions.id}`);
+            }}
+          >
+            Configure
+          </MenuItem>
+        )}
+        {isAdmin && (
+          <MenuItem
+            onClick={(e) => {
+              e.stopPropagation();
+              openRemove(e);
+            }}
+          >
+            Remove
+          </MenuItem>
+        )}
       </Menu>
       <Modal
         aria-labelledby="modal-delete-monitor"
@@ -197,6 +202,7 @@ ActionsMenu.propTypes = {
     url: PropTypes.string,
     type: PropTypes.string,
   }).isRequired,
+  isAdmin: PropTypes.bool,
 };
 
 /**
@@ -261,7 +267,7 @@ const SkeletonLayout = () => {
   );
 };
 
-const Monitors = () => {
+const Monitors = ({ isAdmin }) => {
   const theme = useTheme();
   const navigate = useNavigate();
   const monitorState = useSelector((state) => state.uptimeMonitors);
@@ -340,7 +346,7 @@ const Monitors = () => {
         },
         {
           id: idx + 4,
-          data: <ActionsMenu monitor={monitor} />,
+          data: <ActionsMenu monitor={monitor} isAdmin={isAdmin} />,
         },
       ],
     };
@@ -390,14 +396,16 @@ const Monitors = () => {
               <Typography>
                 It looks like you don’t have any monitors set up yet.
               </Typography>
-              <Button
-                level="primary"
-                label="Create your first monitor"
-                onClick={() => {
-                  navigate("/monitors/create");
-                }}
-                sx={{ mt: theme.gap.large }}
-              />
+              {isAdmin && (
+                <Button
+                  level="primary"
+                  label="Create your first monitor"
+                  onClick={() => {
+                    navigate("/monitors/create");
+                  }}
+                  sx={{ mt: theme.gap.large }}
+                />
+              )}
             </Stack>
           ) : (
             <>
@@ -437,4 +445,7 @@ const Monitors = () => {
   );
 };
 
+Monitors.propTypes = {
+  isAdmin: PropTypes.bool,
+};
 export default Monitors;
diff --git a/Client/src/Pages/PageSpeed/index.jsx b/Client/src/Pages/PageSpeed/index.jsx
index 399597b13..899e48ec1 100644
--- a/Client/src/Pages/PageSpeed/index.jsx
+++ b/Client/src/Pages/PageSpeed/index.jsx
@@ -123,7 +123,7 @@ const SkeletonLayout = () => {
   );
 };
 
-const PageSpeed = () => {
+const PageSpeed = ({ isAdmin }) => {
   const theme = useTheme();
   const dispatch = useDispatch();
   const navigate = useNavigate();
@@ -178,10 +178,14 @@ const PageSpeed = () => {
             "Give suggestions on how the page can be improved",
           ]}
           link="/pagespeed/create"
+          isAdmin={isAdmin}
         />
       )}
     </Box>
   );
 };
+PageSpeed.propTypes = {
+  isAdmin: PropTypes.bool,
+};
 
 export default PageSpeed;