From de673ea5d13ac671550e9931cb1d0e462777d687 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Mon, 9 Jun 2025 14:22:11 +0800
Subject: [PATCH] add notifications to pagespeed

---
 .../ConfigButton/index.jsx                    |   4 +-
 .../src/Pages/PageSpeed/Configure/index.jsx   | 204 ++++++------------
 client/src/Pages/PageSpeed/Create/index.jsx   |  59 ++---
 client/src/Pages/Uptime/Configure/index.jsx   |   6 +-
 client/src/Pages/Uptime/Create/index.jsx      |   6 +-
 client/src/locales/en.json                    |   4 +
 server/db/models/Monitor.js                   |   2 +-
 7 files changed, 87 insertions(+), 198 deletions(-)

diff --git a/client/src/Components/MonitorStatusHeader/ConfigButton/index.jsx b/client/src/Components/MonitorStatusHeader/ConfigButton/index.jsx
index c966abf33..7ad6ae9af 100644
--- a/client/src/Components/MonitorStatusHeader/ConfigButton/index.jsx
+++ b/client/src/Components/MonitorStatusHeader/ConfigButton/index.jsx
@@ -34,8 +34,8 @@ const ConfigButton = ({ shouldRender = true, monitorId, path }) => {
 
 ConfigButton.propTypes = {
 	shouldRender: PropTypes.bool,
-	monitorId: PropTypes.string.isRequired,
-	path: PropTypes.string.isRequired,
+	monitorId: PropTypes.string,
+	path: PropTypes.string,
 };
 
 export default ConfigButton;
diff --git a/client/src/Pages/PageSpeed/Configure/index.jsx b/client/src/Pages/PageSpeed/Configure/index.jsx
index 84e26c6a0..487106247 100644
--- a/client/src/Pages/PageSpeed/Configure/index.jsx
+++ b/client/src/Pages/PageSpeed/Configure/index.jsx
@@ -1,6 +1,19 @@
+// Components
+import { Box, Stack, Tooltip, Typography, Button } from "@mui/material";
+import ConfigBox from "../../../Components/ConfigBox";
+import Select from "../../../Components/Inputs/Select";
+import TextInput from "../../../Components/Inputs/TextInput";
+import PauseCircleOutlineIcon from "@mui/icons-material/PauseCircleOutline";
+import Breadcrumbs from "../../../Components/Breadcrumbs";
+import PulseDot from "../../../Components/Animated/PulseDot";
+import PlayCircleOutlineRoundedIcon from "@mui/icons-material/PlayCircleOutlineRounded";
+import SkeletonLayout from "./skeleton";
+import NotificationsConfig from "../../../Components/NotificationConfig";
+import Dialog from "../../../Components/Dialog";
+
+// Utils
 import { useEffect, useState } from "react";
 import { useTheme } from "@emotion/react";
-import { Box, Stack, Tooltip, Typography, Button } from "@mui/material";
 import { useDispatch, useSelector } from "react-redux";
 import { useNavigate, useParams } from "react-router";
 import {
@@ -12,41 +25,31 @@ import {
 } from "../../../Features/PageSpeedMonitor/pageSpeedMonitorSlice";
 import { monitorValidation } from "../../../Validation/validation";
 import { createToast } from "../../../Utils/toastUtils";
-import { logger } from "../../../Utils/Logger";
 import { useTranslation } from "react-i18next";
-import ConfigBox from "../../../Components/ConfigBox";
-import TextInput from "../../../Components/Inputs/TextInput";
-import Select from "../../../Components/Inputs/Select";
-import Checkbox from "../../../Components/Inputs/Checkbox";
-import PauseCircleOutlineIcon from "@mui/icons-material/PauseCircleOutline";
-import Breadcrumbs from "../../../Components/Breadcrumbs";
-import PulseDot from "../../../Components/Animated/PulseDot";
-import PlayCircleOutlineRoundedIcon from "@mui/icons-material/PlayCircleOutlineRounded";
-import SkeletonLayout from "./skeleton";
 import useUtils from "../../Uptime/Monitors/Hooks/useUtils";
-import "./index.css";
-import Dialog from "../../../Components/Dialog";
+import { useGetNotificationsByTeamId } from "../../../Hooks/useNotifications";
 
 const PageSpeedConfigure = () => {
+	// Redux state
+	const { isLoading } = useSelector((state) => state.pageSpeedMonitors);
+
+	// Local state
+	const [monitor, setMonitor] = useState({});
+	const [errors, setErrors] = useState({});
+	const [buttonLoading, setButtonLoading] = useState(false);
+	const [isOpen, setIsOpen] = useState(false);
+
+	// Utils
 	const theme = useTheme();
 	const { t } = useTranslation();
 	const navigate = useNavigate();
 	const dispatch = useDispatch();
 	const MS_PER_MINUTE = 60000;
-	const { user } = useSelector((state) => state.auth);
-	const { isLoading } = useSelector((state) => state.pageSpeedMonitors);
 	const { monitorId } = useParams();
-	const [monitor, setMonitor] = useState({});
-	const [errors, setErrors] = useState({});
 	const { statusColor, pagespeedStatusMsg, determineState } = useUtils();
-	const [buttonLoading, setButtonLoading] = useState(false);
-	const idMap = {
-		"monitor-url": "url",
-		"monitor-name": "name",
-		"monitor-checks-http": "type",
-		"monitor-checks-ping": "type",
-		"notify-email-default": "notification-email",
-	};
+
+	const [notifications, notificationsAreLoading, notificationsError] =
+		useGetNotificationsByTeamId();
 
 	const frequencies = [
 		{ _id: 3, name: "3 minutes" },
@@ -77,57 +80,29 @@ const PageSpeedConfigure = () => {
 		fetchMonitor();
 	}, [dispatch, monitorId, navigate]);
 
-	const handleChange = (event, name) => {
-		let { value, id } = event.target;
-		if (!name) name = idMap[id];
+	const onChange = (event) => {
+		let { value, name } = event.target;
 
-		if (name.includes("notification-")) {
-			name = name.replace("notification-", "");
-			let hasNotif = monitor.notifications.some(
-				(notification) => notification.type === name
-			);
-			setMonitor((prev) => {
-				const notifs = [...prev.notifications];
-				if (hasNotif) {
-					return {
-						...prev,
-						notifications: notifs.filter((notif) => notif.type !== name),
-					};
-				} else {
-					return {
-						...prev,
-						notifications: [
-							...notifs,
-							name === "email"
-								? { type: name, address: value }
-								: // TODO - phone number
-									{ type: name, phone: value },
-						],
-					};
-				}
-			});
-		} else {
-			if (name === "interval") {
-				value = value * MS_PER_MINUTE;
-			}
-			setMonitor((prev) => ({
-				...prev,
-				[name]: value,
-			}));
-
-			const validation = monitorValidation.validate(
-				{ [name]: value },
-				{ abortEarly: false }
-			);
-
-			setErrors((prev) => {
-				const updatedErrors = { ...prev };
-
-				if (validation.error) updatedErrors[name] = validation.error.details[0].message;
-				else delete updatedErrors[name];
-				return updatedErrors;
-			});
+		if (name === "interval") {
+			value = value * MS_PER_MINUTE;
 		}
+		setMonitor((prev) => ({
+			...prev,
+			[name]: value,
+		}));
+
+		const validation = monitorValidation.validate(
+			{ [name]: value },
+			{ abortEarly: false }
+		);
+
+		setErrors((prev) => {
+			const updatedErrors = { ...prev };
+
+			if (validation.error) updatedErrors[name] = validation.error.details[0].message;
+			else delete updatedErrors[name];
+			return updatedErrors;
+		});
 	};
 
 	const handlePause = async () => {
@@ -142,12 +117,11 @@ const PageSpeedConfigure = () => {
 				throw new Error(action.error.message);
 			}
 		} catch (error) {
-			logger.error("Error pausing monitor: " + monitorId);
 			createToast({ body: "Failed to pause monitor" });
 		}
 	};
 
-	const handleSave = async (event) => {
+	const onSubmit = async (event) => {
 		event.preventDefault();
 		const action = await dispatch(updatePageSpeed({ monitor: monitor }));
 		if (action.meta.requestStatus === "fulfilled") {
@@ -158,7 +132,6 @@ const PageSpeedConfigure = () => {
 		}
 	};
 
-	const [isOpen, setIsOpen] = useState(false);
 	const handleRemove = async (event) => {
 		event.preventDefault();
 		setButtonLoading(true);
@@ -191,7 +164,7 @@ const PageSpeedConfigure = () => {
 						component="form"
 						noValidate
 						spellCheck="false"
-						onSubmit={handleSave}
+						onSubmit={onSubmit}
 						flex={1}
 						gap={theme.spacing(10)}
 					>
@@ -329,24 +302,24 @@ const PageSpeedConfigure = () => {
 								}}
 							>
 								<TextInput
+									name="url"
 									type="url"
-									id="monitor-url"
 									label={t("url")}
 									placeholder="random.website.com"
 									value={monitor?.url || ""}
-									onChange={handleChange}
+									onChange={onChange}
 									error={errors.url ? true : false}
 									helperText={errors.url}
 									disabled={true}
 								/>
 								<TextInput
+									name="name"
 									type="text"
-									id="monitor-name"
 									label={t("monitorDisplayName")}
 									placeholder="Example monitor"
 									isOptional={true}
 									value={monitor?.name || ""}
-									onChange={handleChange}
+									onChange={onChange}
 									error={errors.name ? true : false}
 									helperText={errors.name}
 								/>
@@ -354,64 +327,16 @@ const PageSpeedConfigure = () => {
 						</ConfigBox>
 						<ConfigBox>
 							<Box>
-								<Typography
-									component="h2"
-									variant="h2"
-								>
-									{t("distributedUptimeCreateIncidentNotification")}
-								</Typography>
+								<Typography component="h2">{t("notificationConfig.title")}</Typography>
 								<Typography component="p">
-									{t("distributedUptimeCreateIncidentDescription")}
+									{t("notificationConfig.description")}
 								</Typography>
 							</Box>
-							<Stack gap={theme.spacing(6)}>
-								<Typography component="p">{t("whenNewIncident")}</Typography>
-								{/* Future Feature: Notify via SMS */}
-								{/* <Checkbox
-									id="notify-sms"
-									label={t("notifySMS")}
-									isChecked={false}
-									value=""
-									onChange={() => logger.warn("disabled")}
-									isDisabled={true}
-								/> */}
-								<Checkbox
-									id="notify-email-default"
-									label={`Notify via email (to ${user.email})`}
-									isChecked={
-										monitor?.notifications?.some(
-											(notification) => notification.type === "email"
-										) || false
-									}
-									value={user?.email}
-									onChange={(event) => handleChange(event)}
-								/>
-								{/* Future Feature: Notify via Email */}
-								{/* <Checkbox
-									id="notify-email"
-									label={t("notifyEmails")}
-									isChecked={false}
-									value=""
-									onChange={() => logger.warn("disabled")}
-									isDisabled={true}
-								/> */}
-								{monitor?.notifications?.some(
-									(notification) => notification.type === "emails"
-								) ? (
-									<Box mx={theme.spacing(16)}>
-										<TextInput
-											id="notify-email-list"
-											type="text"
-											placeholder="name@gmail.com"
-											value=""
-											onChange={() => logger.warn("disabled")}
-										/>
-										<Typography mt={theme.spacing(4)}>{t("seperateEmails")}</Typography>
-									</Box>
-								) : (
-									""
-								)}
-							</Stack>
+							<NotificationsConfig
+								notifications={notifications}
+								setMonitor={setMonitor}
+								setNotifications={monitor.notifications}
+							/>
 						</ConfigBox>
 						<ConfigBox>
 							<Box>
@@ -424,11 +349,11 @@ const PageSpeedConfigure = () => {
 							</Box>
 							<Stack gap={theme.spacing(20)}>
 								<Select
-									id="monitor-frequency"
+									name="interval"
 									label={t("checkFrequency")}
 									items={frequencies}
 									value={monitor?.interval / MS_PER_MINUTE || 3}
-									onChange={(event) => handleChange(event, "interval")}
+									onChange={onChange}
 								/>
 							</Stack>
 						</ConfigBox>
@@ -442,7 +367,6 @@ const PageSpeedConfigure = () => {
 								type="submit"
 								variant="contained"
 								color="accent"
-								onClick={handleSave}
 								sx={{ px: theme.spacing(12) }}
 							>
 								{t("settingsSave")}
diff --git a/client/src/Pages/PageSpeed/Create/index.jsx b/client/src/Pages/PageSpeed/Create/index.jsx
index 1d40d4667..2b3e6e4e4 100644
--- a/client/src/Pages/PageSpeed/Create/index.jsx
+++ b/client/src/Pages/PageSpeed/Create/index.jsx
@@ -2,7 +2,6 @@
 import { useNavigate } from "react-router-dom";
 import { useState } from "react";
 import { useSelector, useDispatch } from "react-redux";
-
 // Utility and Network
 import { monitorValidation } from "../../../Validation/validation";
 import {
@@ -11,6 +10,7 @@ import {
 } from "../../../Features/PageSpeedMonitor/pageSpeedMonitorSlice";
 import { parseDomainName } from "../../../Utils/monitorUtils";
 import { useTranslation } from "react-i18next";
+import { useGetNotificationsByTeamId } from "../../../Hooks/useNotifications";
 
 // MUI
 import { useTheme } from "@emotion/react";
@@ -23,8 +23,8 @@ import { HttpAdornment } from "../../../Components/Inputs/TextInput/Adornments";
 import ConfigBox from "../../../Components/ConfigBox";
 import { createToast } from "../../../Utils/toastUtils";
 import Radio from "../../../Components/Inputs/Radio";
-import Checkbox from "../../../Components/Inputs/Checkbox";
 import Select from "../../../Components/Inputs/Select";
+import NotificationsConfig from "../../../Components/NotificationConfig";
 
 const MS_PER_MINUTE = 60000;
 
@@ -57,6 +57,7 @@ const CreatePageSpeed = () => {
 	const [errors, setErrors] = useState({});
 	const { user } = useSelector((state) => state.auth);
 	const { isLoading } = useSelector((state) => state.pageSpeedMonitors);
+	const [notifications, notificationsAreLoading, error] = useGetNotificationsByTeamId();
 
 	// Setup
 	const dispatch = useDispatch();
@@ -64,7 +65,7 @@ const CreatePageSpeed = () => {
 	const theme = useTheme();
 
 	// Handlers
-	const handleCreateMonitor = async (event) => {
+	const onSubmit = async (event) => {
 		event.preventDefault();
 		let form = {
 			url: `http${https ? "s" : ""}://` + monitor.url,
@@ -134,32 +135,6 @@ const CreatePageSpeed = () => {
 		}));
 	};
 
-	const handleNotifications = (event, type) => {
-		const { value } = event.target;
-		let notifications = [...monitor.notifications];
-		const notificationExists = notifications.some((notification) => {
-			if (notification.type === type && notification.address === value) {
-				return true;
-			}
-			return false;
-		});
-		if (notificationExists) {
-			notifications = notifications.filter((notification) => {
-				if (notification.type === type && notification.address === value) {
-					return false;
-				}
-				return true;
-			});
-		} else {
-			notifications.push({ type, address: value });
-		}
-
-		setMonitor((prev) => ({
-			...prev,
-			notifications,
-		}));
-	};
-
 	const handleBlur = (event) => {
 		const { name } = event.target;
 		if (name === "url") {
@@ -189,7 +164,7 @@ const CreatePageSpeed = () => {
 			<Stack
 				component="form"
 				className="create-monitor-form"
-				onSubmit={handleCreateMonitor}
+				onSubmit={onSubmit}
 				noValidate
 				spellCheck="false"
 				gap={theme.spacing(12)}
@@ -312,24 +287,14 @@ const CreatePageSpeed = () => {
 							component="h2"
 							variant="h2"
 						>
-							{t("distributedUptimeCreateIncidentNotification")}
-						</Typography>
-						<Typography component="p">
-							{t("distributedUptimeCreateIncidentDescription")}
+							{t("notificationConfig.title")}
 						</Typography>
+						<Typography component="p">{t("notificationConfig.description")}</Typography>
 					</Box>
-					<Stack gap={theme.spacing(6)}>
-						<Typography component="p">{t("whenNewIncident")}</Typography>
-						<Checkbox
-							id="notify-email-default"
-							label={`Notify via email (to ${user.email})`}
-							isChecked={monitor.notifications.some(
-								(notification) => notification.type === "email"
-							)}
-							value={user?.email}
-							onChange={(event) => handleNotifications(event, "email")}
-						/>
-					</Stack>
+					<NotificationsConfig
+						notifications={notifications}
+						setMonitor={setMonitor}
+					/>
 				</ConfigBox>
 				<ConfigBox>
 					<Box>
@@ -356,9 +321,9 @@ const CreatePageSpeed = () => {
 					justifyContent="flex-end"
 				>
 					<Button
+						type="submit"
 						variant="contained"
 						color="accent"
-						onClick={handleCreateMonitor}
 						disabled={!Object.values(errors).every((value) => value === undefined)}
 						loading={isLoading}
 					>
diff --git a/client/src/Pages/Uptime/Configure/index.jsx b/client/src/Pages/Uptime/Configure/index.jsx
index 9667728cb..8718a2209 100644
--- a/client/src/Pages/Uptime/Configure/index.jsx
+++ b/client/src/Pages/Uptime/Configure/index.jsx
@@ -383,10 +383,8 @@ const Configure = () => {
 				</ConfigBox>
 				<ConfigBox>
 					<Box>
-						<Typography component="h2">Notifications</Typography>
-						<Typography component="p">
-							Select the notifications you want to send out
-						</Typography>
+						<Typography component="h2">{t("notificationConfig.title")}</Typography>
+						<Typography component="p">{t("notificationConfig.description")}</Typography>
 					</Box>
 					<NotificationsConfig
 						notifications={notifications}
diff --git a/client/src/Pages/Uptime/Create/index.jsx b/client/src/Pages/Uptime/Create/index.jsx
index b9e1e8423..c233b2a36 100644
--- a/client/src/Pages/Uptime/Create/index.jsx
+++ b/client/src/Pages/Uptime/Create/index.jsx
@@ -349,10 +349,8 @@ const CreateMonitor = () => {
 				</ConfigBox>
 				<ConfigBox>
 					<Box>
-						<Typography component="h2">Notifications</Typography>
-						<Typography component="p">
-							Select the notifications you want to send out
-						</Typography>
+						<Typography component="h2">{t("notificationConfig.title")}</Typography>
+						<Typography component="p">{t("notificationConfig.description")}</Typography>
 					</Box>
 					<NotificationsConfig
 						notifications={notifications}
diff --git a/client/src/locales/en.json b/client/src/locales/en.json
index 16e1f5ebd..568b654b1 100644
--- a/client/src/locales/en.json
+++ b/client/src/locales/en.json
@@ -166,6 +166,10 @@
 			"integrationKeyPlaceholder": "1234567890"
 		}
 	},
+	"notificationConfig": {
+		"title": "Notifications",
+		"description": "Select the notifications channels you want to use"
+	},
 	"notifications": {
 		"fallback": {
 			"title": "Notification",
diff --git a/server/db/models/Monitor.js b/server/db/models/Monitor.js
index 5fa2834fa..3079abfba 100755
--- a/server/db/models/Monitor.js
+++ b/server/db/models/Monitor.js
@@ -42,7 +42,7 @@ const MonitorSchema = mongoose.Schema(
 		},
 		matchMethod: {
 			type: String,
-			enum: ["equal", "include", "regex"],
+			enum: ["equal", "include", "regex", ""],
 		},
 		url: {
 			type: String,