From ed3b00801608d77190a869b4ff43dd10b8fb8861 Mon Sep 17 00:00:00 2001
From: Alex Holliday <ajhollid@gmail.com>
Date: Mon, 14 Oct 2024 13:13:13 +0800
Subject: [PATCH] Add queue controller tests for getMetrics and getJobs

---
 Server/.nycrc                         |  2 +-
 Server/controllers/queueController.js | 18 +++++++++++++-----
 Server/utils/messages.js              |  4 ++++
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/Server/.nycrc b/Server/.nycrc
index da9bccbfc..d6406bf7e 100644
--- a/Server/.nycrc
+++ b/Server/.nycrc
@@ -1,6 +1,6 @@
 {
   "all": true,
-  "include": ["**/*.js"],
+  "include": ["controllers/*.js"],
   "exclude": ["**/*.test.js"],
   "reporter": ["html", "text", "lcov"],
   "sourceMap": false,
diff --git a/Server/controllers/queueController.js b/Server/controllers/queueController.js
index 341c4b76b..68ab7b28d 100644
--- a/Server/controllers/queueController.js
+++ b/Server/controllers/queueController.js
@@ -1,13 +1,15 @@
 const { handleError } = require("./controllerUtils");
-
+const { errorMessages, successMessages } = require("../utils/messages");
 const SERVICE_NAME = "JobQueueController";
 
 const getMetrics = async (req, res, next) => {
   try {
     const metrics = await req.jobQueue.getMetrics();
-    res
-      .status(200)
-      .json({ success: true, msg: "Metrics retrieved", data: metrics });
+    res.status(200).json({
+      success: true,
+      msg: successMessages.QUEUE_GET_METRICS,
+      data: metrics,
+    });
   } catch (error) {
     next(handleError(error, SERVICE_NAME, "getMetrics"));
     return;
@@ -17,7 +19,13 @@ const getMetrics = async (req, res, next) => {
 const getJobs = async (req, res, next) => {
   try {
     const jobs = await req.jobQueue.getJobStats();
-    return res.status(200).json({ jobs });
+    return res
+      .status(200)
+      .json({
+        success: true,
+        msg: successMessages.QUEUE_GET_METRICS,
+        data: jobs,
+      });
   } catch (error) {
     next(handleError(error, SERVICE_NAME, "getJobs"));
     return;
diff --git a/Server/utils/messages.js b/Server/utils/messages.js
index 16b2f7883..c1df6af3b 100644
--- a/Server/utils/messages.js
+++ b/Server/utils/messages.js
@@ -86,6 +86,10 @@ const successMessages = {
   MONITOR_CERTIFICATE: "Got monitor certificate successfully",
   MONITOR_DEMO_ADDED: "Successfully added demo monitors",
 
+  // Queue Controller
+  QUEUE_GET_METRICS: "Got metrics successfully",
+  QUEUE_GET_METRICS: "Got job stats successfully",
+
   //Job Queue
   JOB_QUEUE_DELETE_JOB: "Job removed successfully",
   JOB_QUEUE_OBLITERATE: "Queue OBLITERATED!!!",