diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 95b5bacbe..9c9ba0c65 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,28 +1,28 @@ -**(Please remove this line only before submitting your PR. Ensure that all relevant items are checked before submission.)** +**(Please remove this line only before submitting your PR. Ensure that all relevant items are checked before submission.)** ## Describe your changes -Briefly describe the changes you made and their purpose. +Briefly describe the changes you made and their purpose. ## Write your issue number after "Fixes " -Fixes #123 +Fixes #123 ## Please ensure all items are checked off before requesting a review. "Checked off" means you need to add an "x" character between brackets so they turn into checkmarks. - [ ] (Do not skip this or your PR will be closed) I deployed the application locally. - [ ] (Do not skip this or your PR will be closed) I have performed a self-reviewing and testing of my code. - [ ] I have included the issue # in the PR. -- [ ] I have added i18n support to visible strings (instead of `
Add
`, use): +- [ ] I have added i18n support to visible strings (instead of `
Add
`, use): + ```Javascript const { t } = useTranslation();
{t('add')}
``` + - [ ] I have **not** included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed - [ ] I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application). - [ ] I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions. - [ ] My PR is granular and targeted to one specific feature. -- [ ] There are two database implementations (MongoDB and PostgreSQL TimescaleDB) and I have taken care of them appropriately. - [ ] I ran `npm run format` in server and client directories, which automatically formats your code. - [ ] I took a screenshot or a video and attached to this PR if there is a UI change. - diff --git a/.gitignore b/.gitignore index 055e3d31e..ff828c1ec 100644 --- a/.gitignore +++ b/.gitignore @@ -3,10 +3,8 @@ .VSCodeCounter *.sh mongo -timescaledb node_modules/ docs/architecture docs/reviews docs/todo -docs/frontend -docs/timescale \ No newline at end of file +docs/frontend \ No newline at end of file diff --git a/server/src/db/IDb.ts b/server/src/db/IDb.ts index e71e36cca..4c719999f 100644 --- a/server/src/db/IDb.ts +++ b/server/src/db/IDb.ts @@ -1,7 +1,4 @@ -import { Pool } from "pg"; - export interface IDb { connect(): Promise; disconnect(): Promise; - getPool(): Pool | null; } diff --git a/server/src/db/MongoDB.ts b/server/src/db/MongoDB.ts index 59d2a32b7..1284aef4d 100755 --- a/server/src/db/MongoDB.ts +++ b/server/src/db/MongoDB.ts @@ -5,7 +5,6 @@ import { ILogger } from "@/utils/logger.js"; import { EnvConfig } from "@/service/system/settingsService.js"; const SERVICE_NAME = "MongoDB"; import { IDb } from "@/db/IDb.js"; -import { Pool } from "pg"; class MongoDB implements IDb { static SERVICE_NAME = SERVICE_NAME; @@ -79,10 +78,6 @@ class MongoDB implements IDb { }); } }; - - getPool = () => { - return null; - }; } export default MongoDB;