gorkem-bwl
a2786a77ec
Apply review feedback: - Extract makeStatusPage from the two test files that duplicated it (test/unit/services/statusPageService.test.ts and test/unit/controllers/statusPageThemeFlag.test.ts) into test/helpers/makeStatusPage.ts. Both files now import the shared helper, matching the existing test/helpers/ convention used for repository fakes and provider contracts - Add a blank line in statusPageController.getStatusPageByUrl between the normalizedMonitors map and the themesEnabled lookup so the response-shaping section breathes a bit - Drop the obsolete localStorage references from the plan doc that survived from an earlier draft of the design — the public page never persisted a per-visitor mode choice in localStorage, so the test bullet under 2.11 and the risk row both pointed at functionality that does not exist
102 lines
3.8 KiB
TypeScript
102 lines
3.8 KiB
TypeScript
import { describe, expect, it, jest } from "@jest/globals";
|
|
import { StatusPageService } from "../../../src/service/business/statusPageService.ts";
|
|
import type { IStatusPagesRepository } from "../../../src/repositories/status-pages/IStatusPagesRepository.ts";
|
|
import { makeStatusPage } from "../../helpers/makeStatusPage.ts";
|
|
|
|
const createRepo = () =>
|
|
({
|
|
create: jest.fn().mockResolvedValue(makeStatusPage()),
|
|
findByUrl: jest.fn().mockResolvedValue(makeStatusPage()),
|
|
findByTeamId: jest.fn().mockResolvedValue([makeStatusPage()]),
|
|
updateById: jest.fn().mockResolvedValue(makeStatusPage()),
|
|
deleteById: jest.fn().mockResolvedValue(makeStatusPage()),
|
|
removeMonitorFromStatusPages: jest.fn().mockResolvedValue(1),
|
|
}) as unknown as jest.Mocked<IStatusPagesRepository>;
|
|
|
|
const createService = () => {
|
|
const repo = createRepo();
|
|
const service = new StatusPageService(repo);
|
|
return { service, repo };
|
|
};
|
|
|
|
// ── Tests ────────────────────────────────────────────────────────────────────
|
|
|
|
describe("StatusPageService", () => {
|
|
describe("createStatusPage", () => {
|
|
it("delegates to repository with all parameters", async () => {
|
|
const { service, repo } = createService();
|
|
const data = { companyName: "New Co" };
|
|
const file = { originalname: "logo.png" } as Express.Multer.File;
|
|
|
|
const result = await service.createStatusPage("user-1", "team-1", file, data);
|
|
|
|
expect(repo.create).toHaveBeenCalledWith("user-1", "team-1", file, data);
|
|
expect(result).toEqual(makeStatusPage());
|
|
});
|
|
|
|
it("passes undefined image when not provided", async () => {
|
|
const { service, repo } = createService();
|
|
|
|
await service.createStatusPage("user-1", "team-1", undefined, {});
|
|
|
|
expect(repo.create).toHaveBeenCalledWith("user-1", "team-1", undefined, {});
|
|
});
|
|
});
|
|
|
|
describe("getStatusPageByUrl", () => {
|
|
it("delegates to repository", async () => {
|
|
const { service, repo } = createService();
|
|
|
|
const result = await service.getStatusPageByUrl("my-status-page");
|
|
|
|
expect(repo.findByUrl).toHaveBeenCalledWith("my-status-page");
|
|
expect(result).toEqual(makeStatusPage());
|
|
});
|
|
});
|
|
|
|
describe("getStatusPagesByTeamId", () => {
|
|
it("delegates to repository", async () => {
|
|
const { service, repo } = createService();
|
|
|
|
const result = await service.getStatusPagesByTeamId("team-1");
|
|
|
|
expect(repo.findByTeamId).toHaveBeenCalledWith("team-1");
|
|
expect(result).toEqual([makeStatusPage()]);
|
|
});
|
|
});
|
|
|
|
describe("updateStatusPage", () => {
|
|
it("delegates to repository with all parameters", async () => {
|
|
const { service, repo } = createService();
|
|
const updated = makeStatusPage({ companyName: "Updated Co" });
|
|
(repo.updateById as jest.Mock).mockResolvedValue(updated);
|
|
const file = { originalname: "new-logo.png" } as Express.Multer.File;
|
|
|
|
const result = await service.updateStatusPage("sp-1", "team-1", file, { companyName: "Updated Co" });
|
|
|
|
expect(repo.updateById).toHaveBeenCalledWith("sp-1", "team-1", file, { companyName: "Updated Co" });
|
|
expect(result).toBe(updated);
|
|
});
|
|
|
|
it("passes theme and themeMode through to the repository", async () => {
|
|
const { service, repo } = createService();
|
|
const patch = { theme: "modern" as const, themeMode: "dark" as const };
|
|
|
|
await service.updateStatusPage("sp-1", "team-1", undefined, patch);
|
|
|
|
expect(repo.updateById).toHaveBeenCalledWith("sp-1", "team-1", undefined, patch);
|
|
});
|
|
});
|
|
|
|
describe("deleteStatusPage", () => {
|
|
it("delegates to repository and returns deleted page", async () => {
|
|
const { service, repo } = createService();
|
|
|
|
const result = await service.deleteStatusPage("sp-1", "team-1");
|
|
|
|
expect(repo.deleteById).toHaveBeenCalledWith("sp-1", "team-1");
|
|
expect(result).toEqual(makeStatusPage());
|
|
});
|
|
});
|
|
});
|