Community Feedback on cache

serverid in cache is pointless and will never change

unit tests are not actually unit tests so i renamed to examples.

lib/cache/client/cache.lua

@@ -3,33 +3,22 @@ local PlayerPedId = PlayerPedId
 local GetVehiclePedIsIn = GetVehiclePedIsIn
 local GetVehicleMaxNumberOfPassengers = GetVehicleMaxNumberOfPassengers
 local GetPedInVehicleSeat = GetPedInVehicleSeat
-local GetPlayerServerId = GetPlayerServerId
 local GetSelectedPedWeapon = GetSelectedPedWeapon
-local PlayerId = PlayerId
-
-
--- Comparison functions for client-side state
-
---- Get the player's ped ID
----@return integer
-function GetPed()
-    return PlayerPedId()
-end
 
 --- Get the vehicle the player is in, if any
 ---@return integer | nil
 function GetVehicle()
-    local ped = Cache.Get("Ped") -- Use cached ped for efficiency
-    if not ped then return end   -- Or handle error/default case
+    local ped = PlayerPedId()
+    if not ped then return end 
     return GetVehiclePedIsIn(ped, false)
 end
 
 --- Get the seat of the player in the vehicle if the vehicle is occupied
 ---@return integer | nil
 function GetVehicleSeat()
-    local vehicle = Cache.Get("Vehicle")
+    local vehicle = GetVehicle()
     if not vehicle then return end
-    local ped = Cache.Get("Ped")
+    local ped = PlayerPedId()
     if not ped then return end
     for i = -1, GetVehicleMaxNumberOfPassengers(vehicle) - 1 do
         if ped == GetPedInVehicleSeat(vehicle, i) then
@@ -38,26 +27,17 @@ function GetVehicleSeat()
     end
 end
 
----Get The Server ID of the player
----@return integer | nil
-function GetServerId()
-    local ped <const> = PlayerId()
-    if not ped then return end -- Return unarmed hash if no ped
-    return GetPlayerServerId(ped)
-end
-
 --- Get the current weapon of the player
 --- @return integer | nil
 function GetWeapon()
-    local ped = Cache.Get("Ped")
+    local ped = PlayerPedId()
     if not ped then return end -- Return unarmed hash if no ped
     return GetSelectedPedWeapon(ped)
 end
 
-Cache.Create("Ped", GetPed, 1000)           -- Check ped every second (adjust as needed)
+Cache.Create("Ped", PlayerPedId, 1000)           -- Check ped every second (adjust as needed)
 Cache.Create("Vehicle", GetVehicle, 500)    -- Check vehicle every 500ms
 Cache.Create("Seat", GetVehicleSeat, 500)   -- Check if in vehicle every 500ms
 Cache.Create("Weapon", GetWeapon , 250)      -- Check weapon every 250ms
-Cache.Create("ServerId", GetServerId, 1000) -- Check server ID every second
 
 return Cache