promisify the resolve method to pass the error to the middleware and updat test cases accordingly
This commit is contained in:
1 parent
7ec5e64f6f
commit
0f763e7913
2 files changed
+14
-16
No files matched your search
@@ -276,18 +276,18 @@ const checkEndpointResolution = async (req, res, next) => {
|
||||
try {
|
||||
let { monitorURL } = req.query;
|
||||
monitorURL = new URL(monitorURL);
|
||||
dns.resolve(monitorURL.hostname, (error) => {
|
||||
if (error) {
|
||||
return res.status(400).json({
|
||||
success: false,
|
||||
msg: `DNS resolution failed`,
|
||||
});
|
||||
}
|
||||
return res.status(200).json({
|
||||
success: true,
|
||||
msg: `URL resolved successfully`,
|
||||
await new Promise((resolve, reject) => {
|
||||
dns.resolve(monitorURL.hostname, (error) => {
|
||||
if (error) {
|
||||
reject(error);
|
||||
}
|
||||
resolve();
|
||||
});
|
||||
});
|
||||
return res.status(200).json({
|
||||
success: true,
|
||||
msg: `URL resolved successfully`,
|
||||
});
|
||||
} catch (error) {
|
||||
next(handleError(error, SERVICE_NAME, "checkEndpointResolution"));
|
||||
}
|
||||
|
||||
@@ -484,12 +484,10 @@ describe('checkEndpointResolution', () => {
|
||||
const dnsError = new Error("DNS resolution failed");
|
||||
dnsResolveStub.callsFake((hostname, callback) => callback(dnsError));
|
||||
await checkEndpointResolution(req, res, next);
|
||||
expect(res.status.calledOnceWith(400)).to.be.true;
|
||||
expect(res.json.calledOnceWith({
|
||||
success: false,
|
||||
msg: "DNS resolution failed",
|
||||
})).to.be.true;
|
||||
expect(next.notCalled).to.be.true;
|
||||
expect(next.calledOnce).to.be.true;
|
||||
const errorPassedToNext = next.getCall(0).args[0];
|
||||
expect(errorPassedToNext).to.be.an.instanceOf(Error);
|
||||
expect(errorPassedToNext.message).to.include('DNS resolution failed');
|
||||
});
|
||||
it('should call next with an error for invalid monitorURL', async () => {
|
||||
req.query.monitorURL = 'invalid-url';
|
||||
|
||||
Reference in new issue
Block a user