fix discarded validation, tighten types

server/src/controllers/maintenanceWindowController.ts

@@ -33,11 +33,11 @@ class MaintenanceWindowController {
 	};
 	getMaintenanceWindowById = async (req: Request, res: Response, next: NextFunction) => {
 		try {
-			getMaintenanceWindowByIdParamValidation.parse(req.params);
+			const validatedParams = getMaintenanceWindowByIdParamValidation.parse(req.params);
 
 			const teamId = requireTeamId(req.user?.teamId);
 
-			const maintenanceWindow = await this.maintenanceWindowService.getMaintenanceWindowById({ id: req.params.id as string, teamId });
+			const maintenanceWindow = await this.maintenanceWindowService.getMaintenanceWindowById({ id: validatedParams.id, teamId });
 
 			return res.status(200).json({
 				success: true,

server/src/validation/maintenanceWindowValidation.ts

@@ -50,7 +50,7 @@ export const editMaintenanceByIdWindowBodyValidation = z.object({
 	start: dateToString.optional(),
 	end: dateToString.optional(),
 	expiry: dateToString.optional(),
-	monitors: z.array(z.unknown()).optional(),
+	monitors: z.array(z.string()).optional(),
 	duration: z.number().optional(),
 	durationUnit: z.enum(["seconds", "minutes", "hours", "days"]).optional(),
 });