chore adding comments
This commit is contained in:
1 parent
5ad5ba7e6f
commit
6c521436ad
3 files changed
+10
-8
No files matched your search
@@ -31,7 +31,9 @@ const icons = {
|
||||
|
||||
const Alert = ({ variant, title, body, isToast, hasIcon = true, onClick }) => {
|
||||
const theme = useTheme();
|
||||
/* TODO check if this still works. text bg and border not necessarilly exist. Text becomes contrastText. border becomes contrastText. bg becomes dark */
|
||||
/* TODO
|
||||
This needs fixing. text bg and border not necessarilly exist. Probably text becomes contrastText. border becomes contrastText. bg becomes dark.
|
||||
Check possible variants, see implementation in light and dark theme, and adjust */
|
||||
const { text, bg, border } = theme.palette[variant];
|
||||
const icon = icons[variant];
|
||||
|
||||
|
||||
@@ -1,4 +1,9 @@
|
||||
const typographyBase = 14;
|
||||
|
||||
/* TODO
|
||||
Check for px in codebase. All font sizes should be in REM and should live here.
|
||||
Rest should be checked on each case
|
||||
*/
|
||||
const typographyLevels = {
|
||||
base: typographyBase,
|
||||
xs: `${(typographyBase - 4) / 16}rem`,
|
||||
|
||||
@@ -4,13 +4,7 @@ import { colors } from "./constants";
|
||||
|
||||
/*
|
||||
TODO
|
||||
Next step: check if all here are being used.
|
||||
*/
|
||||
/* TODO
|
||||
|
||||
Check for Hex in code base
|
||||
|
||||
Check for px in codebase
|
||||
Next step: check if all keys here are being used in the codebase. e.g.: Search codebase for palette.primary; also check for destructuring palette ('= theme.palette')
|
||||
*/
|
||||
|
||||
const {
|
||||
@@ -111,6 +105,7 @@ const palette = {
|
||||
},
|
||||
};
|
||||
|
||||
/* TODO I figured out we could have just one theme by passing mode as parameter for theme function. Implement later */
|
||||
const lightTheme = createTheme({
|
||||
palette,
|
||||
...baseTheme(palette),
|
||||
|
||||
Reference in new issue
Block a user