TRX/Checkmate
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3155 from bluewave-labs/fix/notifications

Browse Source 
fix: replaced monitor with updatedMonitor
This commit is contained in:
Alexander Holliday authored and GitHub committed 2026-01-20 11:51:29 -08:00
2 parents 6160806963 a69091bb28
commit 795146c79b
2 files changed
+13 -5
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts
+12 -4
View File
@@ -86,20 +86,28 @@ class SuperSimpleQueueHelper {
// Step 5 handle notifications (best effort, continue even in event of failure, don't wait)
this.notificationsService
.handleNotifications(monitor, status, statusChangeResult.prevStatus, statusChangeResult.statusChanged)
.handleNotifications(statusChangeResult.monitor, status, statusChangeResult.prevStatus, statusChangeResult.statusChanged)
.catch((error: any) => {
this.logger.error({
message: error.message,
service: SERVICE_NAME,
method: "getMonitorJob",
details: `Error sending notifications for job ${monitor.id}: ${error.message}`,
details: `Error sending notifications for job ${statusChangeResult.monitor.id}: ${error.message}`,
stack: error.stack,
});
});
// Step 6. Handle incidents
// Step 6. Handle incidents (best effort, don't wait)
if (statusChangeResult.statusChanged) {
await this.incidentService.handleIncident(statusChangeResult.monitor, statusChangeResult.code);
this.incidentService.handleIncident(statusChangeResult.monitor, statusChangeResult.code).catch((error: any) => {
this.logger.warn({
message: error.message,
service: SERVICE_NAME,
method: "getMonitorJob",
details: `Error handling incident for job ${monitor.id}: ${error.message}`,
stack: error.stack,
});
});
}
} catch (error: any) {
this.logger.warn({
server/src/service/infrastructure/notificationProviders/utils.ts
+1 -1
View File
@@ -163,7 +163,7 @@ export const buildHardwareEmail = async (emailService: any, monitor: Monitor, al
};
export const buildEmail = async (emailService: any, monitor: Monitor): Promise<string> => {
const template = monitor.status === false ? "serverIsUpTemplate" : "serverIsDownTemplate";
const template = monitor.status === true ? "serverIsUpTemplate" : "serverIsDownTemplate";
const context = { monitor: monitor.name, url: monitor.url };
const html = await emailService.buildEmail(template, context);
return html;