Merge pull request #569 from mertssmnoglu/mertssmnoglu-restful-http-methods

fix: use correct request methods edit=PUT, delete=DELETE

Client/src/Features/UptimeMonitors/uptimeMonitorsSlice.js

@@ -80,7 +80,7 @@ export const updateUptimeMonitor = createAsyncThunk(
         notifications: monitor.notifications,
       };
       const res = await axiosInstance.put(
-        `/monitors/edit/${monitor._id}`,
+        `/monitors/${monitor._id}`,
         updatedFields,
         {
           headers: {

README.md

@@ -76,29 +76,41 @@ Made with [contrib.rocks](https://contrib.rocks).
     ###### Auth
     - <code>POST</code> [/api/v1/auth/register](#post-register)
     - <code>POST</code> [/api/v1/auth/login](#post-login)
-    - <code>POST</code> [/api/v1/auth/user/{userId}](#post-auth-user-edit-id)
+    - <code>PUT</code> [/api/v1/auth/user/{userId}](#post-auth-user-edit-id)
     - <code>GET</code> [/api/v1/auth/users](#get-all-users-id)
+    - <code>GET</code> [/api/v1/auth/users/admin](#get-all-admin-users-id)
+    - <code>POST</code> [/api/v1/auth/invite](#post-auth-invite-id)
+    - <code>POST</code> [/api/v1/auth/invite/verify/](#post-auth-invite-verify-id)
     - <code>POST</code> [/api/v1/auth/recovery/request](#post-auth-recovery-request-id)
     - <code>POST</code> [/api/v1/auth/recovery/validate](#post-auth-recovery-validate-id)
     - <code>POST</code> [/api/v1/auth/recovery/reset](#post-auth-recovery-reset-id)
     ###### Monitors
     - <code>GET</code> [/api/v1/monitors](#get-monitors)
-    - <code>GET</code> [/api/v1/monitor/{id}](#get-monitor-id)
+    - <code>GET</code> [/api/v1/monitors/{monitorId}](#get-monitor-id)
     - <code>GET</code> [/api/v1/monitors/user/{userId}?limit](#get-monitors-user-userid)
     - <code>POST</code> [/api/v1/monitors](#post-monitors)
-    - <code>POST</code> [/api/v1/monitors/delete/{monitorId}](#post-monitors-del-id)
-    - <code>POST</code> [/api/v1/monitors/edit/{monitorId}](#post-monitors-edit-id)
+    - <code>PUT</code> [/api/v1/monitors/{monitorId}](#put-monitors-id)
+    - <code>DELETE</code> [/api/v1/monitors/{monitorId}](#delete-monitors-id)
+    - <code>DELETE</code> [/api/v1/monitors/all](#delete-all-monitors)
     ###### Checks
     - <code>POST</code> [/api/v1/checks/{monitorId}](#post-checks)
     - <code>GET</code> [/api/v1/checks/{monitorId}](#get-checks)
-    - <code>POST</code> [/api/v1/checks/delete/{monitorId}](#delete-checks)
+    - <code>DELETE</code> [/api/v1/checks/{monitorId}](#delete-checks)
     ###### Alerts
     - <code>POST</code> [/api/v1/alerts/{monitorId}](#create-alert)
     - <code>GET</code> [/api/v1/alerts/user/{userId}](#get-alerts-user-id)
     - <code>GET</code> [/api/v1/alerts/monitor/{monitorId}](#get-alerts-monitor-id)
     - <code>GET</code> [/api/v1/alerts/{alertId}](#get-alert-alert-id)
-    - <code>POST</code> [/api/v1/alerts/edit/{alertId}](#edit-alert)
-    - <code>POST</code> [/api/v1/alerts/delete/{alertId}](#delete-alert)
+    - <code>PUT</code> [/api/v1/alerts/{alertId}](#edit-alert)
+    - <code>DELETE</code> [/api/v1/alerts/{alertId}](#delete-alert)
+    ###### Page Speed
+    - <code>POST</code> [/api/v1/pagespeed/:monitorId](#post-pagespeed)
+    - <code>GET</code> [/api/v1/pagespeed/:monitorId](#get-pagespeed)
+    - <code>DELETE</code> [/api/v1/pagespeed/:monitorId](#delete-pagespeed)
+    ###### Maintenance Window
+    - <code>POST</code> [/api/v1/maintenance-window/:monitorId](#post-maintenance-window)
+    - <code>GET</code> [/api/v1/maintenance-window/user/:userId](#get-maintenance-window-by-userid)
+    - <code>GET</code> [/api/v1/maintenance-window/monitor/:monitorId](#get-maintenance-window-by-monitor-id)
 1.  [Error Handling](#error-handling)
 1.  [Contributors](#contributors)
 

Server/routes/alertRoute.js

@@ -29,14 +29,14 @@ router.get(
   alertController.getAlertById
 );
 // Edit
-router.post(
-  "/edit/:alertId",
+router.put(
+  "/:alertId",
   verifyOwnership(Monitor, "monitorId"),
   alertController.editAlert
 );
 //Delete
-router.post(
-  "/delete/:alertId",
+router.delete(
+  "/:alertId",
   verifyOwnership(Monitor, "monitorId"),
   alertController.deleteAlert
 );

Server/routes/checkRoute.js

@@ -15,8 +15,8 @@ router.get(
   checkController.getChecks
 );
 
-router.post(
-  "/delete/:monitorId",
+router.delete(
+  "/:monitorId",
   verifyOwnership(Monitor, "monitorId"),
   checkController.deleteChecks
 );

Server/routes/monitorRoute.js

@@ -14,10 +14,10 @@ router.delete(
   monitorController.deleteMonitor
 );
 router.put(
-  "/edit/:monitorId",
+  "/:monitorId",
   verifyOwnership(Monitor, "monitorId"),
   monitorController.editMonitor
 );
 
-router.delete("/delete/all", monitorController.deleteAllMonitors);
+router.delete("/all", monitorController.deleteAllMonitors);
 module.exports = router;