refactor(status-page): tighten the theme-fields backend after second review

Apply review feedback:
- Extract makeStatusPage from the two test files that duplicated it (test/unit/services/statusPageService.test.ts and test/unit/controllers/statusPageThemeFlag.test.ts) into test/helpers/makeStatusPage.ts. Both files now import the shared helper, matching the existing test/helpers/ convention used for repository fakes and provider contracts
- Add a blank line in statusPageController.getStatusPageByUrl between the normalizedMonitors map and the themesEnabled lookup so the response-shaping section breathes a bit
- Drop the obsolete localStorage references from the plan doc that survived from an earlier draft of the design — the public page never persisted a per-visitor mode choice in localStorage, so the test bullet under 2.11 and the risk row both pointed at functionality that does not exist

server/src/controllers/statusPageController.ts

@@ -130,6 +130,7 @@ class StatusPageController implements IStatusPageController {
 				}
 				return { ...monitor, checks: normalizedChecks };
 			});
+
 			const themesEnabled = this.settingsService.areStatusPageThemesEnabled();
 			return res.status(200).json({
 				success: true,

server/test/helpers/makeStatusPage.ts

@@ -0,0 +1,14 @@
+import type { StatusPage } from "../../src/types/index.ts";
+
+export const makeStatusPage = (overrides?: Partial<StatusPage>): StatusPage =>
+	({
+		id: "sp-1",
+		teamId: "team-1",
+		userId: "user-1",
+		url: "my-status-page",
+		companyName: "Test Co",
+		monitors: ["mon-1"],
+		createdAt: "2026-01-01T00:00:00Z",
+		updatedAt: "2026-01-01T00:00:00Z",
+		...overrides,
+	}) as StatusPage;

server/test/unit/controllers/statusPageThemeFlag.test.ts

@@ -1,22 +1,7 @@
 import { describe, expect, it } from "@jest/globals";
 import { applyDefaultTheme, withoutThemeFields } from "../../../src/controllers/statusPageThemeFlag.ts";
 import { DEFAULT_STATUS_PAGE_THEME, DEFAULT_STATUS_PAGE_THEME_MODE } from "../../../src/types/statusPage.ts";
-import type { StatusPage } from "../../../src/types/index.ts";
-
-const makeStatusPage = (overrides?: Partial<StatusPage>): StatusPage =>
-	({
-		id: "sp-1",
-		teamId: "team-1",
-		userId: "user-1",
-		url: "my-status-page",
-		companyName: "Test Co",
-		monitors: ["mon-1"],
-		theme: "modern",
-		themeMode: "dark",
-		createdAt: "2026-01-01T00:00:00Z",
-		updatedAt: "2026-01-01T00:00:00Z",
-		...overrides,
-	}) as StatusPage;
+import { makeStatusPage } from "../../helpers/makeStatusPage.ts";
 
 describe("statusPageThemeFlag", () => {
 	describe("withoutThemeFields", () => {

server/test/unit/services/statusPageService.test.ts

@@ -1,22 +1,7 @@
 import { describe, expect, it, jest } from "@jest/globals";
 import { StatusPageService } from "../../../src/service/business/statusPageService.ts";
 import type { IStatusPagesRepository } from "../../../src/repositories/status-pages/IStatusPagesRepository.ts";
-import type { StatusPage } from "../../../src/types/index.ts";
-
-// ── Helpers ──────────────────────────────────────────────────────────────────
-
-const makeStatusPage = (overrides?: Partial<StatusPage>): StatusPage =>
-	({
-		id: "sp-1",
-		teamId: "team-1",
-		userId: "user-1",
-		url: "my-status-page",
-		companyName: "Test Co",
-		monitors: ["mon-1"],
-		createdAt: "2026-01-01T00:00:00Z",
-		updatedAt: "2026-01-01T00:00:00Z",
-		...overrides,
-	}) as StatusPage;
+import { makeStatusPage } from "../../helpers/makeStatusPage.ts";
 
 const createRepo = () =>
 	({