Merge pull request #3241 from bluewave-labs/fix/incidents-selector

fix/incidents selector

client/src/Components/v2/inputs/Dialog.tsx

@@ -59,14 +59,16 @@ export const DialogInput = ({
 				>
 					{cancelText ?? t("common.buttons.cancel")}
 				</Button>
-				<Button
-					loading={loading}
-					variant="contained"
-					color={confirmColor}
-					onClick={onConfirm}
-				>
-					{confirmText ?? t("common.buttons.confirm")}
-				</Button>
+				{onConfirm && (
+					<Button
+						loading={loading}
+						variant="contained"
+						color={confirmColor}
+						onClick={onConfirm}
+					>
+						{confirmText ?? t("common.buttons.confirm")}
+					</Button>
+				)}
 			</DialogActions>
 		</Dialog>
 	);

client/src/Pages/Incidents/Components/ControlsIncidentFilter.tsx

@@ -6,7 +6,7 @@ import { Typography, useTheme } from "@mui/material";
 import { useTranslation } from "react-i18next";
 import type { Monitor } from "@/Types/Monitor";
 
-const resolutionTypes = ["manual", "automatic"];
+const resolutionTypes = ["all", "manual", "automatic"];
 
 interface ControlsIncidentFilterProps {
 	monitors?: Monitor[];

client/src/Pages/Incidents/Components/DialogIncidentDetails.tsx

@@ -22,13 +22,15 @@ export const DialogIncidentDetails = ({
 }: DialogIncidentDetailsProps) => {
 	const { t } = useTranslation();
 
+	const isActive = incident?.status === true;
+
 	return (
 		<Dialog
 			open={open}
 			onCancel={onClose}
-			onConfirm={onResolve}
-			cancelText={t("common.buttons.cancel")}
-			confirmText={t("pages.incidents.dialog.details.resolve")}
+			onConfirm={isActive ? onResolve : undefined}
+			cancelText={t("common.buttons.close")}
+			confirmText={isActive ? t("pages.incidents.dialog.details.resolve") : undefined}
 			maxWidth="sm"
 			fullWidth
 		>

client/src/locales/en.json

@@ -188,6 +188,7 @@
 		},
 		"buttons": {
 			"cancel": "Cancel",
+			"close": "Close",
 			"configure": "Configure",
 			"confirm": "Confirm",
 			"create": "Create",
@@ -653,6 +654,10 @@
 					"overview": "Overview",
 					"resolutionDetails": "Resolution details",
 					"resolutionType": "Type:",
+					"resolutionTypes": {
+						"automatic": "Automatic",
+						"manual": "Manual"
+					},
 					"resolve": "Resolve Incident",
 					"resolvedAt": "Resolved at:",
 					"resolvedBy": "Resolved by:",