Fix status page deletion network requests and implement optimistic UI update pattern

This commit is contained in:
mohadeseh safari committed 2025-06-24 15:07:37 -04:00
1 parent a29282801a
commit e371596d15
3 files changed
+37 -11

No files matched your search

+12 -5
View File
@@ -126,11 +126,18 @@ const CreateStatusPage = () => {
setProgress({ value: 0, isLoading: false });
};
const handleDelete = () => {
deleteStatusPage();
setIsDeleteOpen(false);
navigate("/status");
};
/**
* Handle status page deletion with optimistic UI update
* Immediately navigates away without waiting for the deletion to complete
* to prevent unnecessary network requests for the deleted page
*/
const handleDelete = async () => {
setIsDeleteOpen(false);
// Start deletion process but don't wait for it
deleteStatusPage();
// Immediately navigate away to prevent additional fetches for the deleted page
navigate("/status");
};
const handleSubmit = async () => {
let toSubmit = {
@@ -1,19 +1,34 @@
import { useSelector } from "react-redux";
import { useState } from "react";
import { networkService } from "../../../../main";
import { createToast } from "../../../../Utils/toastUtils";
import { useState } from "react";
import { networkService } from "../../../../Utils/NetworkService";
import { createToast } from "../../../../Utils/toastUtils";
import { useTranslation } from "react-i18next";
/**
* Hook for deleting a status page with optimistic UI update
* @param {Function} fetchStatusPage - Function to fetch status page data
* @param {string} url - URL of the status page
* @returns {Array} - [deleteStatusPage function, isLoading state]
*/
const useStatusPageDelete = (fetchStatusPage, url) => {
const [isLoading, setIsLoading] = useState(false);
const { t } = useTranslation();
/**
* Delete a status page with optimistic UI update
* @returns {Promise<boolean>} - Success status
*/
const deleteStatusPage = async () => {
// We don't need to call fetchStatusPage after deletion
// This prevents the 404 error when trying to fetch a deleted status page
try {
setIsLoading(true);
await networkService.deleteStatusPage({ url });
fetchStatusPage?.();
createToast({ body: t("statusPage.deleteSuccess", "Status page deleted successfully") });
return true;
} catch (error) {
createToast({
body: error.message,
body: t("statusPage.deleteFailed", "Failed to delete status page"),
});
return false;
} finally {
+4
View File
@@ -275,6 +275,10 @@
"date&Time": "Date & Time",
"type": "Type",
"statusPageName": "Status page name",
"statusPage": {
"deleteSuccess": "Status page deleted successfully",
"deleteFailed": "Failed to delete status page"
},
"publicURL": "Public URL",
"repeat": "Repeat",
"edit": "Edit",