remove pool references, update docs
This commit is contained in:
1 parent
3e947ca2df
commit
ff08645087
4 files changed
+2
-12
No files matched your search
@@ -14,15 +14,15 @@ Fixes #123
|
|||||||
- [ ] (Do not skip this or your PR will be closed) I have performed a self-reviewing and testing of my code.
|
- [ ] (Do not skip this or your PR will be closed) I have performed a self-reviewing and testing of my code.
|
||||||
- [ ] I have included the issue # in the PR.
|
- [ ] I have included the issue # in the PR.
|
||||||
- [ ] I have added i18n support to visible strings (instead of `<div>Add</div>`, use):
|
- [ ] I have added i18n support to visible strings (instead of `<div>Add</div>`, use):
|
||||||
|
|
||||||
```Javascript
|
```Javascript
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
<div>{t('add')}</div>
|
<div>{t('add')}</div>
|
||||||
```
|
```
|
||||||
|
|
||||||
- [ ] I have **not** included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed
|
- [ ] I have **not** included any files that are not related to my pull request, including package-lock and package-json if dependencies have not changed
|
||||||
- [ ] I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
|
- [ ] I didn't use any hardcoded values (otherwise it will not scale, and will make it difficult to maintain consistency across the application).
|
||||||
- [ ] I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions.
|
- [ ] I made sure font sizes, color choices etc are all referenced from the theme. I don't have any hardcoded dimensions.
|
||||||
- [ ] My PR is granular and targeted to one specific feature.
|
- [ ] My PR is granular and targeted to one specific feature.
|
||||||
- [ ] There are two database implementations (MongoDB and PostgreSQL TimescaleDB) and I have taken care of them appropriately.
|
|
||||||
- [ ] I ran `npm run format` in server and client directories, which automatically formats your code.
|
- [ ] I ran `npm run format` in server and client directories, which automatically formats your code.
|
||||||
- [ ] I took a screenshot or a video and attached to this PR if there is a UI change.
|
- [ ] I took a screenshot or a video and attached to this PR if there is a UI change.
|
||||||
|
|
||||||
@@ -3,10 +3,8 @@
|
|||||||
.VSCodeCounter
|
.VSCodeCounter
|
||||||
*.sh
|
*.sh
|
||||||
mongo
|
mongo
|
||||||
timescaledb
|
|
||||||
node_modules/
|
node_modules/
|
||||||
docs/architecture
|
docs/architecture
|
||||||
docs/reviews
|
docs/reviews
|
||||||
docs/todo
|
docs/todo
|
||||||
docs/frontend
|
docs/frontend
|
||||||
docs/timescale
|
|
||||||
@@ -1,7 +1,4 @@
|
|||||||
import { Pool } from "pg";
|
|
||||||
|
|
||||||
export interface IDb {
|
export interface IDb {
|
||||||
connect(): Promise<void>;
|
connect(): Promise<void>;
|
||||||
disconnect(): Promise<void>;
|
disconnect(): Promise<void>;
|
||||||
getPool(): Pool | null;
|
|
||||||
}
|
}
|
||||||
@@ -5,7 +5,6 @@ import { ILogger } from "@/utils/logger.js";
|
|||||||
import { EnvConfig } from "@/service/system/settingsService.js";
|
import { EnvConfig } from "@/service/system/settingsService.js";
|
||||||
const SERVICE_NAME = "MongoDB";
|
const SERVICE_NAME = "MongoDB";
|
||||||
import { IDb } from "@/db/IDb.js";
|
import { IDb } from "@/db/IDb.js";
|
||||||
import { Pool } from "pg";
|
|
||||||
|
|
||||||
class MongoDB implements IDb {
|
class MongoDB implements IDb {
|
||||||
static SERVICE_NAME = SERVICE_NAME;
|
static SERVICE_NAME = SERVICE_NAME;
|
||||||
@@ -79,10 +78,6 @@ class MongoDB implements IDb {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
getPool = () => {
|
|
||||||
return null;
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export default MongoDB;
|
export default MongoDB;
|
||||||
Reference in new issue
Block a user