Changed delete status code to 200 to allow for consistent API response, Updated docs to reflect this
This commit is contained in:
1 parent
f4b0034281
commit
54c94879d7
2 files changed
+11
-2
No files matched your search
@@ -454,7 +454,7 @@ curl --request POST \
|
||||
> | ---- | ------------------- |
|
||||
> | None | No payload returned |
|
||||
|
||||
##### Sample CURL request
|
||||
###### Sample CURL request
|
||||
|
||||
```
|
||||
curl --request POST \
|
||||
@@ -463,6 +463,15 @@ curl --request POST \
|
||||
--header 'Content-Type: application/json' \
|
||||
```
|
||||
|
||||
###### Sample Response
|
||||
|
||||
```json
|
||||
{
|
||||
"success": true,
|
||||
"msg": "Monitor deleted"
|
||||
}
|
||||
```
|
||||
|
||||
## </details>
|
||||
|
||||
---
|
||||
|
||||
@@ -135,7 +135,7 @@ const deleteMonitor = async (req, res) => {
|
||||
* when it is deleted so there is no orphaned data
|
||||
* We also need to make sure to stop all running services for this monitor
|
||||
*/
|
||||
return res.status(204).json({ success: true, msg: "Monitor deleted" });
|
||||
return res.status(200).json({ success: true, msg: "Monitor deleted" });
|
||||
} catch (error) {
|
||||
logger.error(error.message, { service: "monitor" });
|
||||
return res.status(500).json({ success: false, msg: error.message });
|
||||
|
||||
Reference in new issue
Block a user